Reedy has submitted this change and it was merged.
Change subject: UploadStash::removeFileNoAuth shouldn't need auth
......................................................................
UploadStash::removeFileNoAuth shouldn't need auth
UploadStash::getFile has a "noAuth" parameter, which should be set true
when this is called from UploadStash::removeFileNoAuth.
Callers should already be doing their own auth checking, or calling
UploadStash::removeFile.
Bug: 56298
Change-Id: Ic70c4e2bc6df5cb9b139a3631766f8ff0ec4ef02
(cherry picked from commit d4b250ad380b024620b724c9f9485e79ea712798)
---
M includes/upload/UploadStash.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Reedy: Verified; Looks good to me, approved
diff --git a/includes/upload/UploadStash.php b/includes/upload/UploadStash.php
index ebeb9c1..7db6c64 100644
--- a/includes/upload/UploadStash.php
+++ b/includes/upload/UploadStash.php
@@ -358,7 +358,7 @@
wfDebug( __METHOD__ . " clearing row $key\n" );
// Ensure we have the UploadStashFile loaded for this key
- $this->getFile( $key );
+ $this->getFile( $key, true );
$dbw = $this->repo->getMasterDb();
--
To view, visit https://gerrit.wikimedia.org/r/92544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70c4e2bc6df5cb9b139a3631766f8ff0ec4ef02
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.22wmf22
Gerrit-Owner: Reedy <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
