Kaldari has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92586


Change subject: Moving mobile notifications overlay to stable
......................................................................

Moving mobile notifications overlay to stable

Also fixing styling of archive link so that it lines up with
notifications in the overlay.

Change-Id: I27ab0d8c2ea7423956fa9bf88b48a75ce03b2ea9
---
M includes/Resources.php
M less/modules/NotificationsOverlay.less
2 files changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/86/92586/1

diff --git a/includes/Resources.php b/includes/Resources.php
index d1ec534..ae2eaf1 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -330,7 +330,6 @@
                'scripts' => array(
                        'javascripts/modules/mf-toggle-dynamic.js',
                        'javascripts/modules/talk/talk.js',
-                       'javascripts/modules/notifications/notifications.js',
                        'javascripts/modules/search/pageImages.js',
                        'javascripts/modules/languages/preferred.js',
                        'javascripts/modules/lastEdited/lastEditedBeta.js',
@@ -346,10 +345,6 @@
 
                        // for talk.js
                        'mobile-frontend-talk-overlay-header',
-
-                       // notifications.js (defined in Echo)
-                       'echo-none',
-                       'notifications',
 
                        // newbieUploads.js
                        'mobile-frontend-lead-image-tutorial-summary',
@@ -567,6 +562,7 @@
                        'javascripts/common/ContentOverlay.js',
                        'javascripts/modules/tutorials/PageActionOverlay.js',
                        'javascripts/modules/tutorials/newbieEditor.js',
+                       'javascripts/modules/notifications/notifications.js',
                ),
                'messages' => array(
                        // for mf-toggle.js
diff --git a/less/modules/NotificationsOverlay.less 
b/less/modules/NotificationsOverlay.less
index 429c453..ed198c1 100644
--- a/less/modules/NotificationsOverlay.less
+++ b/less/modules/NotificationsOverlay.less
@@ -32,6 +32,7 @@
        }
        #notifications-archive-link {
                display: block;
-               padding: 12px 0 20px 40px;
+               margin: 1em;
+               padding-left: 10px;
        }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/92586
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27ab0d8c2ea7423956fa9bf88b48a75ce03b2ea9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to