jenkins-bot has submitted this change and it was merged.
Change subject: Check for undefined as well
......................................................................
Check for undefined as well
Currently breaking the _rtfrom/
Introduced in 560c79e9a1ee8d01bc9cc4b862f280fa6752a610.
Change-Id: I2c9cced3bd99bd33b36314ba2ce2be86d58e368f
---
M js/lib/mediawiki.DOMPostProcessor.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
GWicke: Looks good to me, approved
jenkins-bot: Verified
diff --git a/js/lib/mediawiki.DOMPostProcessor.js
b/js/lib/mediawiki.DOMPostProcessor.js
index 079b247..179e4f7 100644
--- a/js/lib/mediawiki.DOMPostProcessor.js
+++ b/js/lib/mediawiki.DOMPostProcessor.js
@@ -256,7 +256,9 @@
// use the metadataMap to turn collected data into <meta> and <link>
tags.
m.forEach(function( g, f ) {
var mdm = metadataMap[f];
- if ( !m.has(f) || m.get(f) === null || !mdm ) { return; }
+ if ( !m.has(f) || m.get(f) === null || m.get(f) === undefined
|| !mdm ) {
+ return;
+ }
// generate proper attributes for the <meta> or <link> tag
var attrs = Object.create( null );
Object.keys( mdm ).forEach(function( k ) {
--
To view, visit https://gerrit.wikimedia.org/r/92425
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c9cced3bd99bd33b36314ba2ce2be86d58e368f
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits