[MediaWiki-commits] [Gerrit] revert annoying TRIGGER logging from civi core. - change (wikimedia...civicrm)

[Adamw (Code Review)]

Adamw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92673


Change subject: revert annoying TRIGGER logging from civi core.
......................................................................

revert annoying TRIGGER logging from civi core.

The intention was to catch new and substantial usages of triggers, but this
has not happened yet.  So the logging is annoying.

Change-Id: I01c1074196a582be1758a568ac203bfa5f979bd4
---
M CRM/Core/DAO.php
M CRM/Core/I18n/Schema.php
M CRM/Logging/Schema.php
3 files changed, 6 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm/civicrm 
refs/changes/73/92673/1

diff --git a/CRM/Core/DAO.php b/CRM/Core/DAO.php
index 1457a21..bd55a6c 100644
--- a/CRM/Core/DAO.php
+++ b/CRM/Core/DAO.php
@@ -1476,7 +1476,6 @@
 
     if ($trigger) {
       //$dao->query('CREATE TRIGGER civicrm_domain_trigger BEFORE INSERT ON 
civicrm_domain FOR EACH ROW BEGIN END');
-      error_log('CREATE TRIGGER civicrm_domain_trigger BEFORE INSERT ON 
civicrm_domain FOR EACH ROW BEGIN END');
 
       if (PEAR::getStaticProperty('DB_DataObject', 'lastError')) {
         CRM_Core_Error::setCallback();
@@ -1487,7 +1486,6 @@
       }
 
       //$dao->query('DROP TRIGGER IF EXISTS civicrm_domain_trigger');
-      error_log('DROP TRIGGER IF EXISTS civicrm_domain_trigger');
       if (PEAR::getStaticProperty('DB_DataObject', 'lastError')) {
         CRM_Core_Error::setCallback();
         if ($view) {
@@ -1637,8 +1635,6 @@
             FALSE
           );
                  */
-          error_log("DROP TRIGGER IF EXISTS $triggerName");
-          error_log($triggerSQL);
         }
       }
     }
diff --git a/CRM/Core/I18n/Schema.php b/CRM/Core/I18n/Schema.php
index b700f04..bc76188 100644
--- a/CRM/Core/I18n/Schema.php
+++ b/CRM/Core/I18n/Schema.php
@@ -221,7 +221,6 @@
           $event = $triggerInfo['event'];
           $triggerName = "{$table}_{$when}_{$event}";
           //CRM_Core_DAO::executeQuery("DROP TRIGGER IF EXISTS 
{$triggerName}");
-          error_log("DROP TRIGGER IF EXISTS {$triggerName}");
         }
       }
 
diff --git a/CRM/Logging/Schema.php b/CRM/Logging/Schema.php
index 06f51a8..2409d61 100644
--- a/CRM/Logging/Schema.php
+++ b/CRM/Logging/Schema.php
@@ -120,14 +120,14 @@
 
     foreach ($tableNames as $table) {
       // before triggers
-      error_log("DROP TRIGGER IF EXISTS {$table}_before_insert");
-      error_log("DROP TRIGGER IF EXISTS {$table}_before_update");
-      error_log("DROP TRIGGER IF EXISTS {$table}_before_delete");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_before_insert");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_before_update");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_before_delete");
 
      // after triggers
-      error_log("DROP TRIGGER IF EXISTS {$table}_after_insert");
-      error_log("DROP TRIGGER IF EXISTS {$table}_after_update");
-      error_log("DROP TRIGGER IF EXISTS {$table}_after_delete");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_after_insert");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_after_update");
+      //error_log("DROP TRIGGER IF EXISTS {$table}_after_delete");
     }
   }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/92673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01c1074196a582be1758a568ac203bfa5f979bd4
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm/civicrm
Gerrit-Branch: master
Gerrit-Owner: Adamw <awi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits