Mwalker has submitted this change and it was merged.
Change subject: Bugfix for the child contribution getter. I would like this
query not to return a row of nulls if there are no matches.
......................................................................
Bugfix for the child contribution getter.
I would like this query not to return a row of nulls if there are no matches.
Change-Id: Ie85f172cd1f5840a17cab5988e40e18f7e72a5e3
---
M sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mwalker: Verified; Looks good to me, approved
diff --git a/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
b/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
index 62d3658..f1bff4a 100644
--- a/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
@@ -1091,7 +1091,7 @@
function wmf_civicrm_get_child_contributions_from_gateway_id( $gateway,
$gateway_txn_id ){
$gateway = strtolower( $gateway );
$query = "SELECT cx.*, cc.* FROM wmf_contribution_extra cxp
- LEFT JOIN wmf_contribution_extra cx ON cxp.entity_id =
cx.parent_contribution_id
+ INNER JOIN wmf_contribution_extra cx ON cxp.entity_id =
cx.parent_contribution_id
LEFT JOIN civicrm_contribution cc ON cc.id = cx.entity_id
WHERE cxp.gateway LIKE :gateway AND cxp.gateway_txn_id LIKE
:gateway_txn_id";
--
To view, visit https://gerrit.wikimedia.org/r/92780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie85f172cd1f5840a17cab5988e40e18f7e72a5e3
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
