jenkins-bot has submitted this change and it was merged.
Change subject: Fix bug in popup loading script
......................................................................
Fix bug in popup loading script
Shouldn't load for logged-out users!
Change-Id: I72b419f06319d6b4a1e89647515ef1311ca48521
---
M BetaFeaturesHooks.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/BetaFeaturesHooks.php b/BetaFeaturesHooks.php
index b5020e5..e8412fe 100644
--- a/BetaFeaturesHooks.php
+++ b/BetaFeaturesHooks.php
@@ -397,7 +397,8 @@
* @return bool
*/
static function loadPopupScript( OutputPage &$out, Skin &$skin ) {
- if ( !$out->getUser()->getOption( 'betafeatures-popup-disable'
) ) {
+ $user = $out->getUser();
+ if ( $user->isLoggedIn() && $user->getOption(
'betafeatures-popup-disable' ) ) {
$out->addModules( 'ext.betaFeatures.popup' );
}
--
To view, visit https://gerrit.wikimedia.org/r/92776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72b419f06319d6b4a1e89647515ef1311ca48521
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
