jenkins-bot has submitted this change and it was merged.
Change subject: mw.loader.store: temporarily allow users to opt-in via cookie
......................................................................
mw.loader.store: temporarily allow users to opt-in via cookie
To facilitate mw.loader.store testing on production wikis, it would be good to
allow developers and JavaScript-savvy users to opt-in for mw.loader.store
testing by manually setting a cookie in their browser. With this patch in
place, this would be possible to do by executing the following statement in a
debug console:
$.cookie( 'ResourceLoaderStorageEnabled', 1, { expires: 7, path: '/' } );
This will be removed from mediawiki.js (long) before the 1.23 release.
Bug: 56397
Change-Id: I51cfd563734a3aeed3667fbb19bf3be40fabbb6b
---
M resources/mediawiki/mediawiki.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js
index f1b3082..9267a49 100644
--- a/resources/mediawiki/mediawiki.js
+++ b/resources/mediawiki/mediawiki.js
@@ -1799,14 +1799,18 @@
* code for a full account of why we
need a try / catch: <http://git.io/4NEwKg>.
*/
init: function () {
- var raw, data;
+ var raw, data, optedIn;
if ( mw.loader.store.enabled
!== null ) {
// #init already ran.
return;
}
- if ( !mw.config.get(
'wgResourceLoaderStorageEnabled' ) || mw.config.get( 'debug' ) ) {
+ // Temporarily allow users to
opt-in during mw.loader.store test phase by
+ // manually setting a cookie
(bug 56397).
+ optedIn =
/ResourceLoaderStorageEnabled=1/.test( document.cookie );
+
+ if ( !( mw.config.get(
'wgResourceLoaderStorageEnabled' ) || optedIn ) || mw.config.get( 'debug' ) ) {
// Disabled by
configuration, or because debug mode is set.
mw.loader.store.enabled
= false;
return;
--
To view, visit https://gerrit.wikimedia.org/r/92791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51cfd563734a3aeed3667fbb19bf3be40fabbb6b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
