Adamw has submitted this change and it was merged.
Change subject: Fix for wmf_civicrm_mark_refund
......................................................................
Fix for wmf_civicrm_mark_refund
Zero is a valid count with a rowcount of 1.
The very next "if" always errors.
Change-Id: I5fd86c0b74688d3e29b9752c101124b2d20497dc
---
M sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adamw: Verified; Looks good to me, approved
diff --git a/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
b/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
index f1bff4a..ce2eadd 100644
--- a/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
+++ b/sites/all/modules/wmf_common/wmf_civicrm/wmf_civicrm.module
@@ -1173,7 +1173,7 @@
// Look for existing refunds
$query = <<<"EOS"
-SELECT COUNT(*) FROM wmf_contribution_extra
+SELECT id FROM wmf_contribution_extra
WHERE
parent_contribution_id = :id
OR (entity_id = :id AND COALESCE(parent_contribution_id, 0))
--
To view, visit https://gerrit.wikimedia.org/r/92815
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fd86c0b74688d3e29b9752c101124b2d20497dc
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Katie Horn <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
