jenkins-bot has submitted this change and it was merged.
Change subject: use getOldid and getNewid methods in DifferenceEngineTest
......................................................................
use getOldid and getNewid methods in DifferenceEngineTest
- instead of direct variable access.
Change-Id: I019017ca1b4f3c2a511e703bc65b93a8ce47fae9
---
M tests/phpunit/includes/diff/DifferenceEngineTest.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/diff/DifferenceEngineTest.php
b/tests/phpunit/includes/diff/DifferenceEngineTest.php
index a10c024..738121a 100644
--- a/tests/phpunit/includes/diff/DifferenceEngineTest.php
+++ b/tests/phpunit/includes/diff/DifferenceEngineTest.php
@@ -87,8 +87,8 @@
$diffEngine = new DifferenceEngine( $this->context,
$old, $new, 2, true, false );
$diffEngine->loadRevisionData();
- $this->assertEquals( $diffEngine->mOldid, $expectedOld,
$message );
- $this->assertEquals( $diffEngine->mNewid, $expectedNew,
$message );
+ $this->assertEquals( $diffEngine->getOldid(),
$expectedOld, $message );
+ $this->assertEquals( $diffEngine->getNewid(),
$expectedNew, $message );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/92852
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I019017ca1b4f3c2a511e703bc65b93a8ce47fae9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
