Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92856
Change subject: (hotfix) Checking for property to lock property input
......................................................................
(hotfix) Checking for property to lock property input
(bug 56296)
Instead of checking for the value, the property id needs to be checked to lock
the property input element. This prevents the property input box from receiving
focus when adding a new claim to an already existing claim list.
Change-Id: I8260becda68d4f3027f01d154e1e52ab7e852f8b
---
M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
M repo/tests/selenium/statements/statements_spec.rb
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/56/92856/1
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
index 2b59489..148bcbf 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js
@@ -136,7 +136,7 @@
},
locked: {
mainSnak: {
- property:
!!value
+ property:
!!propertyId
}
}
};
diff --git a/repo/tests/selenium/statements/statements_spec.rb
b/repo/tests/selenium/statements/statements_spec.rb
index 2448b98..445e274 100644
--- a/repo/tests/selenium/statements/statements_spec.rb
+++ b/repo/tests/selenium/statements/statements_spec.rb
@@ -190,6 +190,14 @@
page.entityLabelSpan.should == properties_cm[0]["label"]
end
end
+ it "should check whether property input does not exist when adding an
additional statement to a statement group" do
+ on_page(ItemPage) do |page|
+ page.navigate_to items[0]["url"]
+ page.wait_for_entity_to_load
+ page.addClaimToFirstStatement
+ page.entitySelectorInput?.should be_false
+ end
+ end
it "should check removing of claim/statement" do
on_page(ItemPage) do |page|
page.navigate_to items[0]["url"]
--
To view, visit https://gerrit.wikimedia.org/r/92856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8260becda68d4f3027f01d154e1e52ab7e852f8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.23-wmf1
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
