jenkins-bot has submitted this change and it was merged. Change subject: Cleanup lib/includes/serializers ......................................................................
Cleanup lib/includes/serializers Change-Id: I776358b0b9dbfcc0b525c8d6aef0a135d2d119b2 --- M lib/includes/serializers/AliasSerializer.php M lib/includes/serializers/ByPropertyListSerializer.php M lib/includes/serializers/ByPropertyListUnserializer.php M lib/includes/serializers/ClaimSerializer.php M lib/includes/serializers/ClaimsSerializer.php M lib/includes/serializers/DescriptionSerializer.php M lib/includes/serializers/EntitySerializer.php M lib/includes/serializers/ItemSerializer.php M lib/includes/serializers/LabelSerializer.php M lib/includes/serializers/MultilingualSerializer.php M lib/includes/serializers/PropertySerializer.php M lib/includes/serializers/ReferenceSerializer.php M lib/includes/serializers/SerializationOptions.php M lib/includes/serializers/Serializer.php M lib/includes/serializers/SerializerFactory.php M lib/includes/serializers/SerializerObject.php M lib/includes/serializers/SiteLinkSerializer.php M lib/includes/serializers/SnakSerializer.php M lib/includes/serializers/Unserializer.php M repo/includes/serializers/EntityRevisionSerializer.php 20 files changed, 40 insertions(+), 176 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/includes/serializers/AliasSerializer.php b/lib/includes/serializers/AliasSerializer.php index 19b7607..9cf8b4f 100644 --- a/lib/includes/serializers/AliasSerializer.php +++ b/lib/includes/serializers/AliasSerializer.php @@ -11,8 +11,6 @@ * * @since 0.4 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Tobias Gritschacher < [email protected] > * @author Katie Filbert < [email protected] > @@ -92,6 +90,7 @@ * * @param array $data * + * @throws InvalidArgumentException * @return array */ public function newFromSerialization( array $data ) { @@ -119,8 +118,9 @@ } /** - * @param array + * @param array $aliasSet * + * @throws InvalidArgumentException * @return string[] */ protected function extractAliasValues( array $aliasSet ) { diff --git a/lib/includes/serializers/ByPropertyListSerializer.php b/lib/includes/serializers/ByPropertyListSerializer.php index d14629a..f62c928 100644 --- a/lib/includes/serializers/ByPropertyListSerializer.php +++ b/lib/includes/serializers/ByPropertyListSerializer.php @@ -5,31 +5,12 @@ use Traversable; use InvalidArgumentException; use Wikibase\ByPropertyIdArray; -use Wikibase\DataModel\Entity\PropertyId; /** * Serializer for Traversable objects that need to be grouped * per property id. Each element needs to have a getPropertyId method. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.2 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/lib/includes/serializers/ByPropertyListUnserializer.php b/lib/includes/serializers/ByPropertyListUnserializer.php index ca99b9e..f6d5e52 100644 --- a/lib/includes/serializers/ByPropertyListUnserializer.php +++ b/lib/includes/serializers/ByPropertyListUnserializer.php @@ -9,25 +9,7 @@ * Serializer for Traversable objects that need to be grouped * per property id. Each element needs to have a getPropertyId method. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.4 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -73,7 +55,6 @@ foreach ( $byPropId as $serializedElement ) { $element = $this->elementUnserializer->newFromSerialization( $serializedElement ); - // FIXME: usage of deprecated method getPrefixedId $elementPropertyId = $element->getPropertyId()->getPrefixedId(); if ( $elementPropertyId !== $propertyId ) { diff --git a/lib/includes/serializers/ClaimSerializer.php b/lib/includes/serializers/ClaimSerializer.php index be5019f..2a82a08 100644 --- a/lib/includes/serializers/ClaimSerializer.php +++ b/lib/includes/serializers/ClaimSerializer.php @@ -4,6 +4,9 @@ use InvalidArgumentException; use OutOfBoundsException; +use Wikibase\ReferenceList; +use Wikibase\Snak; +use Wikibase\SnakList; use Wikibase\Statement; use Wikibase\Claim; @@ -13,8 +16,6 @@ * See docs/json.wiki for details of the format. * * @since 0.2 - * - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -102,6 +103,7 @@ $serialization['qualifiers-order'] = array(); foreach( $claim->getQualifiers() as $snak ) { + /** @var Snak $snak $id */ $id = $snak->getPropertyId()->getPrefixedId(); if( !in_array( $id, $serialization['qualifiers-order'] ) ) { $serialization['qualifiers-order'][] = $snak->getPropertyId()->getPrefixedId(); @@ -202,7 +204,7 @@ $references[] = $referenceUnserializer->newFromSerialization( $referenceSerialization ); } - $claim->setReferences( new \Wikibase\ReferenceList( $references ) ); + $claim->setReferences( new ReferenceList( $references ) ); } } @@ -216,12 +218,12 @@ * * @param array $serialization * @param SnakSerializer $snakUnserializer - * @return \Wikibase\SnakList + * @return SnakList * @throws OutOfBoundsException */ protected function unserializeQualifiers( $serialization, $snakUnserializer ) { if ( !array_key_exists( 'qualifiers', $serialization ) ) { - return new \Wikibase\SnakList(); + return new SnakList(); } else { $sortedQualifiers = array(); @@ -251,7 +253,7 @@ } $snaksUnserializer = new ByPropertyListUnserializer( $snakUnserializer ); - return new \Wikibase\SnakList( $snaksUnserializer->newFromSerialization( $sortedQualifiers ) ); + return new SnakList( $snaksUnserializer->newFromSerialization( $sortedQualifiers ) ); } } diff --git a/lib/includes/serializers/ClaimsSerializer.php b/lib/includes/serializers/ClaimsSerializer.php index 68dd4d8..21fefff 100644 --- a/lib/includes/serializers/ClaimsSerializer.php +++ b/lib/includes/serializers/ClaimsSerializer.php @@ -13,8 +13,6 @@ * * @since 0.3 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > */ @@ -31,7 +29,7 @@ * @throws InvalidArgumentException */ public function getSerialized( $claims ) { - if ( !( $claims instanceof \Wikibase\Claims ) ) { + if ( !( $claims instanceof Claims ) ) { throw new InvalidArgumentException( 'ClaimsSerializer can only serialize Claims objects' ); } diff --git a/lib/includes/serializers/DescriptionSerializer.php b/lib/includes/serializers/DescriptionSerializer.php index 8405e7f..f4360fa 100644 --- a/lib/includes/serializers/DescriptionSerializer.php +++ b/lib/includes/serializers/DescriptionSerializer.php @@ -11,8 +11,6 @@ * * @since 0.4 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Tobias Gritschacher < [email protected] > * @author Katie Filbert < [email protected] > @@ -93,6 +91,7 @@ * * @param array $data * + * @throws InvalidArgumentException * @return array */ public function newFromSerialization( array $data ) { diff --git a/lib/includes/serializers/EntitySerializer.php b/lib/includes/serializers/EntitySerializer.php index 0812640..1ae3604 100644 --- a/lib/includes/serializers/EntitySerializer.php +++ b/lib/includes/serializers/EntitySerializer.php @@ -4,7 +4,6 @@ use InvalidArgumentException; use Wikibase\DataModel\Entity\BasicEntityIdParser; -use Wikibase\DataModel\Entity\EntityIdValue; use Wikibase\Entity; use Wikibase\EntityFactory; @@ -65,7 +64,7 @@ * * @since 0.2 * - * @param EntitySerializationOptions $options + * @param SerializationOptions $options * @param EntityFactory $entityFactory */ public function __construct( SerializationOptions $options, EntityFactory $entityFactory = null ) { diff --git a/lib/includes/serializers/ItemSerializer.php b/lib/includes/serializers/ItemSerializer.php index 5bf09a7..c41e690 100644 --- a/lib/includes/serializers/ItemSerializer.php +++ b/lib/includes/serializers/ItemSerializer.php @@ -2,7 +2,7 @@ namespace Wikibase\Lib\Serializers; use InvalidArgumentException; -use Wikibase\DataModel\SimpleSiteLink; +use SiteSQLStore; use Wikibase\Entity; use Wikibase\Item; @@ -12,8 +12,6 @@ * See docs/json.wiki for details of the format. * * @since 0.2 - * - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -26,7 +24,7 @@ /** * @since 0.4 * - * @var \SiteSQLStore + * @var SiteSQLStore */ protected $siteStore; @@ -36,10 +34,11 @@ * @since 0.4 * * @param SerializationOptions $options + * @param SiteSQLStore $siteStore */ - public function __construct( SerializationOptions $options, \SiteSQLStore $siteStore = null ) { + public function __construct( SerializationOptions $options, SiteSQLStore $siteStore = null ) { if ( $siteStore === null ) { - $this->siteStore = \SiteSQLStore::newInstance(); + $this->siteStore = SiteSQLStore::newInstance(); } else { $this->siteStore = $siteStore; } @@ -86,10 +85,11 @@ * @return Item */ public function newFromSerialization( array $data ) { + /** @var Item $item */ $item = parent::newFromSerialization( $data ); if ( array_key_exists( 'sitelinks', $data ) ) { - $siteLinkSerializer = new SiteLinkSerializer( $this->options ); + $siteLinkSerializer = new SiteLinkSerializer( $this->options, $this->siteStore ); $siteLinks = $siteLinkSerializer->newFromSerialization( $data['sitelinks'] ); foreach( $siteLinks as $siteLink ) { diff --git a/lib/includes/serializers/LabelSerializer.php b/lib/includes/serializers/LabelSerializer.php index 117ea07..4f4ea48 100644 --- a/lib/includes/serializers/LabelSerializer.php +++ b/lib/includes/serializers/LabelSerializer.php @@ -11,8 +11,6 @@ * * @since 0.4 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Tobias Gritschacher < [email protected] > * @author Katie Filbert < [email protected] > @@ -93,6 +91,7 @@ * * @param array $data * + * @throws InvalidArgumentException * @return array $labels */ public function newFromSerialization( array $data ) { diff --git a/lib/includes/serializers/MultilingualSerializer.php b/lib/includes/serializers/MultilingualSerializer.php index c0d61dd..ef01ad5 100644 --- a/lib/includes/serializers/MultilingualSerializer.php +++ b/lib/includes/serializers/MultilingualSerializer.php @@ -2,28 +2,12 @@ namespace Wikibase\Lib\Serializers; +use Wikibase\LanguageFallbackChain; + /** * Multilingual serializer, for serializer of labels and descriptions. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.4 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ */ @@ -107,6 +91,7 @@ $languageFallbackChains = $this->options->getLanguageFallbackChains(); if ( $languageFallbackChains ) { + /** @var LanguageFallbackChain[] $languageFallbackChains */ foreach ( $languageFallbackChains as $languageCode => $languageFallbackChain ) { $data = $languageFallbackChain->extractPreferredValue( $allData ); if ( $data !== null ) { diff --git a/lib/includes/serializers/PropertySerializer.php b/lib/includes/serializers/PropertySerializer.php index 334f1a7..2fdc062 100644 --- a/lib/includes/serializers/PropertySerializer.php +++ b/lib/includes/serializers/PropertySerializer.php @@ -13,8 +13,6 @@ * * @since 0.3 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > * @author Katie Filbert < [email protected] > @@ -53,10 +51,11 @@ /** * @param array $data * - * $return Property + * @return Property * @throws InvalidArgumentException */ public function newFromSerialization( array $data ) { + /** @var Property $entity */ $entity = parent::newFromSerialization( $data ); if ( !array_key_exists( 'datatype', $data ) ) { diff --git a/lib/includes/serializers/ReferenceSerializer.php b/lib/includes/serializers/ReferenceSerializer.php index aa92cbf..ce77a71 100644 --- a/lib/includes/serializers/ReferenceSerializer.php +++ b/lib/includes/serializers/ReferenceSerializer.php @@ -5,6 +5,7 @@ use InvalidArgumentException; use OutOfBoundsException; use Wikibase\Reference; +use Wikibase\SnakList; /** * Serializer for Reference objects. @@ -12,8 +13,6 @@ * See docs/json.wiki for details of the format. * * @since 0.3 - * - * @ingroup Wikibase * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -105,7 +104,7 @@ $snaks = $snaksUnserializer->newFromSerialization( $sortedSnaks ); - $reference = new Reference( new \Wikibase\SnakList( $snaks ) ); + $reference = new Reference( new SnakList( $snaks ) ); if ( array_key_exists( 'hash', $serialization ) && $serialization['hash'] !== $reference->getHash() ) { throw new InvalidArgumentException( 'If a hash is present in a reference serialization it needs to be correct' ); diff --git a/lib/includes/serializers/SerializationOptions.php b/lib/includes/serializers/SerializationOptions.php index bc23356..8865ea4 100644 --- a/lib/includes/serializers/SerializationOptions.php +++ b/lib/includes/serializers/SerializationOptions.php @@ -3,9 +3,7 @@ namespace Wikibase\Lib\Serializers; use InvalidArgumentException; -use ValueFormatters\ValueFormatter; use Wikibase\LanguageFallbackChainFactory; -use Wikibase\Lib\PropertyDataTypeLookup; /** * Options for Serializer objects. diff --git a/lib/includes/serializers/Serializer.php b/lib/includes/serializers/Serializer.php index 3a4d091..802b236 100644 --- a/lib/includes/serializers/Serializer.php +++ b/lib/includes/serializers/Serializer.php @@ -11,25 +11,7 @@ * for conciseness and can contain a lot of redundant info, and are thus often not * ideal for serialization for internal storage. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.3 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/lib/includes/serializers/SerializerFactory.php b/lib/includes/serializers/SerializerFactory.php index de54cfb..a9e59dd 100644 --- a/lib/includes/serializers/SerializerFactory.php +++ b/lib/includes/serializers/SerializerFactory.php @@ -8,25 +8,7 @@ /** * Factory for constructing Serializer and Unserializer objects. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.4 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -115,8 +97,9 @@ /** * @param string $entityType + * @param $options * - * @throws OutOfBoundsException + * @throws InvalidArgumentException * @return Unserializer */ public function newUnserializerForEntity( $entityType, $options ) { diff --git a/lib/includes/serializers/SerializerObject.php b/lib/includes/serializers/SerializerObject.php index 6913485..bf79545 100644 --- a/lib/includes/serializers/SerializerObject.php +++ b/lib/includes/serializers/SerializerObject.php @@ -5,27 +5,9 @@ /** * Base class for ApiSerializers. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * TODO: change to PDO like options as done in ValueParsers * * @since 0.3 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/lib/includes/serializers/SiteLinkSerializer.php b/lib/includes/serializers/SiteLinkSerializer.php index dffe674..348e25f 100644 --- a/lib/includes/serializers/SiteLinkSerializer.php +++ b/lib/includes/serializers/SiteLinkSerializer.php @@ -16,8 +16,6 @@ * * @since 0.4 * - * @ingroup WikibaseLib - * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > * @author John Erling Blad < [email protected] > @@ -191,8 +189,9 @@ } /** - * @param array $badges + * @param array $data * + * @throws InvalidArgumentException * @return ItemId[] */ protected function extractBadges( array $data ) { diff --git a/lib/includes/serializers/SnakSerializer.php b/lib/includes/serializers/SnakSerializer.php index 0e23b6c..d6abefb 100644 --- a/lib/includes/serializers/SnakSerializer.php +++ b/lib/includes/serializers/SnakSerializer.php @@ -2,7 +2,9 @@ namespace Wikibase\Lib\Serializers; +use DataValues\DataValueFactory; use InvalidArgumentException; +use Wikibase\EntityId; use Wikibase\Snak; use Wikibase\SnakObject; @@ -12,8 +14,6 @@ * See docs/json.wiki for details of the format. * * @since 0.2 - * - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > @@ -67,11 +67,11 @@ public function newFromSerialization( array $serialization ) { // TODO: inject id parser $constructorArguments = array( - \Wikibase\EntityId::newFromPrefixedId( $serialization['property'] ), + EntityId::newFromPrefixedId( $serialization['property'] ), ); if ( array_key_exists( 'datavalue', $serialization ) ) { - $constructorArguments[] = \DataValues\DataValueFactory::singleton()->newFromArray( $serialization['datavalue'] ); + $constructorArguments[] = DataValueFactory::singleton()->newFromArray( $serialization['datavalue'] ); } return SnakObject::newFromType( $serialization['snaktype'], $constructorArguments ); diff --git a/lib/includes/serializers/Unserializer.php b/lib/includes/serializers/Unserializer.php index ee26d40..620271d 100644 --- a/lib/includes/serializers/Unserializer.php +++ b/lib/includes/serializers/Unserializer.php @@ -5,25 +5,7 @@ /** * Interface for service objects doing unserialization. * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * * @since 0.4 - * - * @file - * @ingroup WikibaseLib * * @licence GNU GPL v2+ * @author Jeroen De Dauw < [email protected] > diff --git a/repo/includes/serializers/EntityRevisionSerializer.php b/repo/includes/serializers/EntityRevisionSerializer.php index 4008e3b..53f4a52 100644 --- a/repo/includes/serializers/EntityRevisionSerializer.php +++ b/repo/includes/serializers/EntityRevisionSerializer.php @@ -2,16 +2,12 @@ namespace Wikibase\Serializers; -use ApiResult; use InvalidArgumentException; -use MWException; use Wikibase\Entity; use Wikibase\EntityRevision; use Wikibase\EntityTitleLookup; use Wikibase\Lib\Serializers\EntitySerializer; -use Wikibase\Repo\WikibaseRepo; use Wikibase\LanguageFallbackChain; -use Wikibase\LanguageFallbackChainFactory; use Wikibase\Lib\Serializers\SerializerObject; use Wikibase\Lib\Serializers\SerializationOptions; use Wikibase\Lib\Serializers\SerializerFactory; @@ -42,7 +38,7 @@ * * @since 0.5 * - * @param \Wikibase\EntityTitleLookup $titleLookup + * @param EntityTitleLookup $titleLookup * @param EntityRevisionSerializationOptions $options */ public function __construct( EntityTitleLookup $titleLookup, EntityRevisionSerializationOptions $options = null ) { @@ -93,7 +89,7 @@ * * @since 0.5 * - * @param \Wikibase\EntityTitleLookup $titleLookup + * @param EntityTitleLookup $titleLookup * @param string $primaryLanguage * @param LanguageFallbackChain $languageFallbackChain * @@ -102,7 +98,7 @@ public static function newForFrontendStore( EntityTitleLookup $titleLookup, $primaryLanguage, LanguageFallbackChain $languageFallbackChain ) { $SerializationOptions = new SerializationOptions(); - + $SerializationOptions->setOption( EntitySerializer::OPT_PARTS, array( 'labels', 'descriptions', 'datatype' ) ); $SerializationOptions->setLanguages( array( $primaryLanguage => $languageFallbackChain ) ); -- To view, visit https://gerrit.wikimedia.org/r/92646 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I776358b0b9dbfcc0b525c8d6aef0a135d2d119b2 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <[email protected]> Gerrit-Reviewer: Addshore <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
