Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92884


Change subject: Fix: getDataFromDom tests should check for body or head
......................................................................

Fix: getDataFromDom tests should check for body or head

This wasn't updated when Roan split html into body & head, so
0 tests were running!

Change-Id: I4396b94426b2009f20707d64bf3d0f1ae651dbc8
---
M modules/ve/test/ve.test.utils.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/84/92884/1

diff --git a/modules/ve/test/ve.test.utils.js b/modules/ve/test/ve.test.utils.js
index 31cfec2..6f94ea2 100644
--- a/modules/ve/test/ve.test.utils.js
+++ b/modules/ve/test/ve.test.utils.js
@@ -56,7 +56,7 @@
        ve.dm.modelRegistry.register( ve.dm.PreformattedNode );
 
        for ( msg in cases ) {
-               if ( cases[msg].html !== undefined ) {
+               if ( cases[msg].head !== undefined || cases[msg].body !== 
undefined ) {
                        n++;
                        if ( cases[msg].storeItems ) {
                                n += cases[msg].storeItems.length;
@@ -66,7 +66,7 @@
        QUnit.expect( n );
 
        for ( msg in cases ) {
-               if ( cases[msg].html !== undefined ) {
+               if ( cases[msg].head !== undefined || cases[msg].body !== 
undefined ) {
                        doc = new ve.dm.Document( [] );
                        store = doc.getStore();
                        internalList = doc.getInternalList();

-- 
To view, visit https://gerrit.wikimedia.org/r/92884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4396b94426b2009f20707d64bf3d0f1ae651dbc8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to