Brion VIBBER has submitted this change and it was merged.
Change subject: Remove AppCompat dependency for now
......................................................................
Remove AppCompat dependency for now
Maven Android's aar support still seems a little lacking, and
we are going to be 4.0 only for now anyway. This randomly causes
tests to fail at runtime because of not being able to locate the
resources in that project (since it is imported as a jar).
Change-Id: I618b25167659afb7fddf8b86a4700fd733e32355
---
M pom.xml
M wikipedia/pom.xml
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/pom.xml b/pom.xml
index cab5152..54d76db 100644
--- a/pom.xml
+++ b/pom.xml
@@ -43,12 +43,6 @@
<artifactId>support-v4</artifactId>
<version>18.0.0</version>
</dependency>
- <dependency>
- <groupId>com.android.support</groupId>
- <artifactId>appcompat-v7</artifactId>
- <version>18.0.0</version>
- <type>aar</type>
- </dependency>
</dependencies>
</dependencyManagement>
diff --git a/wikipedia/pom.xml b/wikipedia/pom.xml
index d761c15..8575576 100644
--- a/wikipedia/pom.xml
+++ b/wikipedia/pom.xml
@@ -28,12 +28,6 @@
<type>jar</type>
</dependency>
<dependency>
- <groupId>com.android.support</groupId>
- <artifactId>appcompat-v7</artifactId>
- <version>18.0.0</version>
- <type>aar</type>
- </dependency>
- <dependency>
<groupId>org.mediawiki.api</groupId>
<artifactId>json</artifactId>
<version>1.0-SNAPSHOT</version>
--
To view, visit https://gerrit.wikimedia.org/r/92822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I618b25167659afb7fddf8b86a4700fd733e32355
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
