Brion VIBBER has submitted this change and it was merged.
Change subject: Rename the new AsyncTask to be less of a mouthful.
......................................................................
Rename the new AsyncTask to be less of a mouthful.
Also pretty accurately named, I'd think :)
Change-Id: I378991ee547eaf7206b8ecc0ce721fc7a6bbb678
---
M
wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/concurrency/AsyncTaskTest.java
R wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/concurrency/AsyncTaskTest.java
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/concurrency/AsyncTaskTest.java
index 524041e..0c6609d 100644
---
a/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/concurrency/AsyncTaskTest.java
+++
b/wikipedia-it/src/main/java/org/wikimedia/wikipedia/test/concurrency/AsyncTaskTest.java
@@ -2,7 +2,7 @@
import android.content.Intent;
import android.test.ActivityUnitTestCase;
-import org.wikimedia.wikipedia.concurrency.ExceptionHandlingAsyncTask;
+import org.wikimedia.wikipedia.concurrency.SaneAsyncTask;
import org.wikimedia.wikipedia.test.TestDummyActivity;
import java.util.concurrent.*;
@@ -34,7 +34,7 @@
runTestOnUiThread(new Runnable() {
@Override
public void run() {
- new ExceptionHandlingAsyncTask<Integer>(getDefaultExecutor()) {
+ new SaneAsyncTask<Integer>(getDefaultExecutor()) {
@Override
public void onFinish(Integer result) {
assertEquals(returned, result);
@@ -62,7 +62,7 @@
runTestOnUiThread(new Runnable() {
@Override
public void run() {
- new ExceptionHandlingAsyncTask<Void>(getDefaultExecutor()) {
+ new SaneAsyncTask<Void>(getDefaultExecutor()) {
@Override
public void onFinish(Void result) {
assertTrue("onFinish called despite exception", false);
@@ -90,7 +90,7 @@
@Override
public void run() {
final Thread callingThread = Thread.currentThread();
- new ExceptionHandlingAsyncTask<Thread>(getDefaultExecutor()) {
+ new SaneAsyncTask<Thread>(getDefaultExecutor()) {
@Override
public void onBeforeExecute() {
assertSame(callingThread, Thread.currentThread());
diff --git
a/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/ExceptionHandlingAsyncTask.java
b/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
similarity index 94%
rename from
wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/ExceptionHandlingAsyncTask.java
rename to
wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
index b4f7f65..c0cebfd 100644
---
a/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/ExceptionHandlingAsyncTask.java
+++
b/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
@@ -4,7 +4,7 @@
import java.util.concurrent.Executor;
-public abstract class ExceptionHandlingAsyncTask<T> {
+public abstract class SaneAsyncTask<T> {
private final BackingAsyncTask underlyingTask;
private final Executor executor;
@@ -12,7 +12,7 @@
/**
* @param executor The executor on which this Task will run.
*/
- public ExceptionHandlingAsyncTask(Executor executor) {
+ public SaneAsyncTask(Executor executor) {
this.executor = executor;
underlyingTask = new BackingAsyncTask();
}
--
To view, visit https://gerrit.wikimedia.org/r/92831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I378991ee547eaf7206b8ecc0ce721fc7a6bbb678
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
