Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92921


Change subject: Remove a bunch of dangling commas in param lists.
......................................................................

Remove a bunch of dangling commas in param lists.

Puppet 2.7.7 chokes on these!

Change-Id: Id8a5d8efa8fe3b1d004c21d72668dccaa04a2f81
---
M manifests/mail.pp
M manifests/misc/fundraising.pp
M manifests/misc/logging.pp
M manifests/misc/udp2log.pp
M manifests/role/coredb.pp
M manifests/role/redisdb.pp
M manifests/zuul.pp
M modules/sysctl/manifests/conffile.pp
M modules/sysctl/manifests/parameters.pp
9 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/21/92921/1

diff --git a/manifests/mail.pp b/manifests/mail.pp
index 16b14ea..c699d2a 100644
--- a/manifests/mail.pp
+++ b/manifests/mail.pp
@@ -305,7 +305,7 @@
                $short_report_template = 'false',
                $otrs_rule_scores = 'false',
                $spamd_user = 'spamd',
-               $spamd_group = 'spamd',
+               $spamd_group = 'spamd'
        ) {
        include network::constants
 
diff --git a/manifests/misc/fundraising.pp b/manifests/misc/fundraising.pp
index d3a0ccd..72ed08b 100644
--- a/manifests/misc/fundraising.pp
+++ b/manifests/misc/fundraising.pp
@@ -180,7 +180,7 @@
                $user = 'root',
                $hour,
                $minute,
-               $weekday = '*',
+               $weekday = '*'
        ) {
 
        file {
@@ -207,7 +207,7 @@
                $user = 'root',
                $hour,
                $minute,
-               $weekday = '*',
+               $weekday = '*'
        ) {
 
        file {
diff --git a/manifests/misc/logging.pp b/manifests/misc/logging.pp
index c720a01..c1b8659 100644
--- a/manifests/misc/logging.pp
+++ b/manifests/misc/logging.pp
@@ -55,7 +55,7 @@
        $listen_port,
        $destination_ip,
        $destination_port,
-       $multicast = false,
+       $multicast = false
 )
 {
        require misc::logging::socat
diff --git a/manifests/misc/udp2log.pp b/manifests/misc/udp2log.pp
index 46cbddd..4944e74 100644
--- a/manifests/misc/udp2log.pp
+++ b/manifests/misc/udp2log.pp
@@ -186,7 +186,7 @@
        $packet_loss_log     = undef,
        $monitor_packet_loss = true,
        $monitor_processes   = true,
-       $monitor_log_age     = true,
+       $monitor_log_age     = true
 ) {
        require misc::udp2log::monitoring
 
diff --git a/manifests/role/coredb.pp b/manifests/role/coredb.pp
index 00e324c..a64499d 100644
--- a/manifests/role/coredb.pp
+++ b/manifests/role/coredb.pp
@@ -269,7 +269,7 @@
        $enable_unsafe_locks = false,
        $large_slave_trans_retries = false,
        $slow_query_digest = true,
-       $heartbeat_enabled = true,
+       $heartbeat_enabled = true
        ) inherits role::coredb::config {
 
        $cluster = $logical_cluster
diff --git a/manifests/role/redisdb.pp b/manifests/role/redisdb.pp
index 1e8b75b..2493b88 100644
--- a/manifests/role/redisdb.pp
+++ b/manifests/role/redisdb.pp
@@ -7,7 +7,7 @@
 
 class role::db::redis (
        $maxmemory = inline_template("<%= (Float(memorysize.split[0]) * 
0.82).round %>Gb"),
-       $redis_replication = undef,
+       $redis_replication = undef
 ) {
        $cluster = "redis"
 
diff --git a/manifests/zuul.pp b/manifests/zuul.pp
index f5b5568..6981c76 100644
--- a/manifests/zuul.pp
+++ b/manifests/zuul.pp
@@ -14,7 +14,7 @@
                $git_branch='master',
                $git_dir='/var/lib/zuul/git',
                $push_change_refs,
-               $statsd_host = '',
+               $statsd_host = ''
        ) {
 
                        # Zuul needs an API key to interact with Jenkins:
diff --git a/modules/sysctl/manifests/conffile.pp 
b/modules/sysctl/manifests/conffile.pp
index 11e2581..ffb5d32 100644
--- a/modules/sysctl/manifests/conffile.pp
+++ b/modules/sysctl/manifests/conffile.pp
@@ -7,7 +7,7 @@
     $file     = $title,
     $content  = undef,
     $source   = undef,
-    $priority = '10',
+    $priority = '10'
 ) {
     include sysctl
 
diff --git a/modules/sysctl/manifests/parameters.pp 
b/modules/sysctl/manifests/parameters.pp
index 8142ae9..66ed44c 100644
--- a/modules/sysctl/manifests/parameters.pp
+++ b/modules/sysctl/manifests/parameters.pp
@@ -7,7 +7,7 @@
     $values,
     $ensure   = present,
     $file     = $title,
-    $priority = '10',
+    $priority = '10'
 ) {
     sysctl::conffile { $file:
         ensure   => $ensure,

-- 
To view, visit https://gerrit.wikimedia.org/r/92921
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8a5d8efa8fe3b1d004c21d72668dccaa04a2f81
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to