jenkins-bot has submitted this change and it was merged.
Change subject: Treat action=submit as 'alreadyediting'
......................................................................
Treat action=submit as 'alreadyediting'
This fixes an issue where action=submit users saw the one-button CTA.
They now see no CTA, just like action=edit.
When you do a GET request to action=submit, it treats it as an edit,
since there is no text submitted (used for preview or submit with POST
to action=submit). However, wgAction is still 'submit'.
All returns to a returnto/returntoquery URL use GET.
Change-Id: I4ce1dd391c2aa6f8115991793f584a7c170210c1
---
M resources/ext.gettingstarted.return.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Swalling: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/ext.gettingstarted.return.js
b/resources/ext.gettingstarted.return.js
index f7a1469..28701c4 100644
--- a/resources/ext.gettingstarted.return.js
+++ b/resources/ext.gettingstarted.return.js
@@ -202,7 +202,7 @@
* @return {string} kind of page.
*/
getPageKind: function () {
- if ( cfg.wgAction === 'edit' ) {
+ if ( cfg.wgAction === 'edit' || cfg.wgAction ===
'submit' ) {
return 'alreadyediting';
}
--
To view, visit https://gerrit.wikimedia.org/r/91034
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ce1dd391c2aa6f8115991793f584a7c170210c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Halfak <ahalfa...@wikimedia.org>
Gerrit-Reviewer: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: Swalling <swall...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
