Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93010
Change subject: Make default implementation of onCaught throw an Exception
......................................................................
Make default implementation of onCaught throw an Exception
Since otherwise exceptions are silently swallowed unless you
explicitly catch them.
Change-Id: Ib52eebf320f7702ad4387045aa21e61e3da4b39d
---
M wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/10/93010/1
diff --git
a/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
b/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
index c0cebfd..1932538 100644
---
a/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
+++
b/wikipedia/src/main/java/org/wikimedia/wikipedia/concurrency/SaneAsyncTask.java
@@ -42,10 +42,12 @@
* <p/>
* Called on the UI Thread.
*
+ * Default implementation just throws it as a RuntimeException, so
exceptions are never swallowed.
+ *
* @param caught The exception that was thrown.
*/
public void onCatch(Throwable caught) {
-
+ throw new RuntimeException(caught);
}
--
To view, visit https://gerrit.wikimedia.org/r/93010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52eebf320f7702ad4387045aa21e61e3da4b39d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
