jenkins-bot has submitted this change and it was merged.
Change subject: Improve active toolbar detection for terms table
......................................................................
Improve active toolbar detection for terms table
(bug 55949)
When editing a "language term", the copyright tooltip shows up on the button
corresponding to the term being edited.
Change-Id: I638d4b38922b876ef94146949b807aa0b11310a2
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index b223008..75eb860 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -254,6 +254,13 @@
if( !$activeToolbar.length ) {
return; // no toolbar for some reason,
just stop
+ } else if ( $( 'table.wb-terms' ).hasClass(
'wb-edit' ) ) {
+ // TODO: When having multiple empty
EditableValues which are initialized in edit
+ // mode, every EditableValue has the
same classes assigned. This check should
+ // either be made more generic (not
just invoked for the terms table) or an
+ // improved detection of the active
toolbar be implemented.
+ $activeToolbar = origin.getSubject()
+ .find(
'.wikibase-toolbareditgroup-ineditmode' );
}
var toolbar = $activeToolbar.data(
'toolbareditgroup' )
--
To view, visit https://gerrit.wikimedia.org/r/92495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I638d4b38922b876ef94146949b807aa0b11310a2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
