Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93064
Change subject: Remove the JavaScript edit preference
......................................................................
Remove the JavaScript edit preference
All editing is JavaScript based now.
Change-Id: Ifb1ba487ba28863bcc32241df73afffc81709e21
---
M Translate.i18n.php
M Translate.php
M utils/TranslationEditPage.php
M utils/UserToggles.php
4 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/64/93064/1
diff --git a/Translate.i18n.php b/Translate.i18n.php
index 75e27cf..dfbf9e7 100644
--- a/Translate.i18n.php
+++ b/Translate.i18n.php
@@ -158,7 +158,6 @@
The default list of languages depends on your language.',
'translate-pref-editassistlang-bad' => 'Invalid language code in the
list:
<nowiki>$1</nowiki>.',
- 'translate-pref-jsedit' => 'Enhanced translation editor (JavaScript)',
'right-translate' => 'Edit using the translate interface',
'right-translate-manage' => 'Manage message groups',
diff --git a/Translate.php b/Translate.php
index 9203a06..45069bb 100644
--- a/Translate.php
+++ b/Translate.php
@@ -154,11 +154,9 @@
// Custom preferences
$wgDefaultUserOptions['translate'] = 0;
$wgDefaultUserOptions['translate-editlangs'] = 'default';
-$wgDefaultUserOptions['translate-jsedit'] = 1;
$wgDefaultUserOptions['translate-recent-groups'] = '';
$wgHooks['GetPreferences'][] = 'TranslatePreferences::onGetPreferences';
$wgHooks['GetPreferences'][] =
'TranslatePreferences::translationAssistLanguages';
-$wgHooks['GetPreferences'][] = 'TranslatePreferences::translationJsedit';
// Recent changes filters
$wgHooks['SpecialRecentChangesQuery'][] =
'TranslateRcFilter::translationFilter';
diff --git a/utils/TranslationEditPage.php b/utils/TranslationEditPage.php
index f30dc54..607f6e3 100644
--- a/utils/TranslationEditPage.php
+++ b/utils/TranslationEditPage.php
@@ -238,10 +238,6 @@
public static function jsEdit( Title $title, $group = "", $type =
'default' ) {
$context = RequestContext::getMain();
- if ( !$context->getUser()->getOption( 'translate-jsedit' ) ) {
- return array();
- }
-
if ( $type === 'default' ) {
$text = 'tqe-anchor-' . substr( sha1(
$title->getPrefixedText() ), 0, 12 );
$onclick = "jQuery( '#$text' ).dblclick(); return
false;";
diff --git a/utils/UserToggles.php b/utils/UserToggles.php
index dc152de..030a302 100644
--- a/utils/UserToggles.php
+++ b/utils/UserToggles.php
@@ -81,24 +81,6 @@
}
/**
- * Add 'translate-jsedit' preference.
- * An option to disable the javascript edit interface.
- *
- * @param User $user
- * @param array $preferences
- * @return bool true
- */
- public static function translationJsedit( User $user, &$preferences ) {
- $preferences['translate-jsedit'] = array(
- 'class' => 'HTMLCheckField',
- 'section' => 'editing/translate',
- 'label-message' => 'translate-pref-jsedit',
- );
-
- return true;
- }
-
- /**
* JavsScript selector for language codes.
* @return JsSelectToInput
*/
--
To view, visit https://gerrit.wikimedia.org/r/93064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb1ba487ba28863bcc32241df73afffc81709e21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
