Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93068
Change subject: Bug 55477: MultimediaViewer hi-DPI support
......................................................................
Bug 55477: MultimediaViewer hi-DPI support
Multiply target dimensions by $.devicePixelRatio() when fetching
image for the viewer lightbox.
Change-Id: I5d64d21ecc563486a6f7d4709cebc129ef77f930
---
M MultimediaViewer.php
M js/ext.multimediaViewer.js
2 files changed, 7 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer
refs/changes/68/93068/1
diff --git a/MultimediaViewer.php b/MultimediaViewer.php
index 93fe8be..2211f7d 100644
--- a/MultimediaViewer.php
+++ b/MultimediaViewer.php
@@ -69,6 +69,7 @@
'mediawiki.Title',
'jquery.ui.dialog',
'jquery.spinner',
+ 'jquery.hidpi',
),
'messages' => array(
diff --git a/js/ext.multimediaViewer.js b/js/ext.multimediaViewer.js
index 36c35df..622300f 100755
--- a/js/ext.multimediaViewer.js
+++ b/js/ext.multimediaViewer.js
@@ -125,6 +125,7 @@
lightboxHooks.register( 'imageResize', function () {
var api = new mw.Api(),
ratio = this.isFullScreen ? 0.9 : 0.5,
+ density = $.devicePixelRatio(),
filename = viewer.currentImageFilename,
ui = this;
@@ -134,8 +135,8 @@
titles: filename,
prop: 'imageinfo',
iiprop: 'url',
- iiurlwidth: Math.floor( ratio * $( window
).width() * 1.1 ),
- iiurlheight: Math.floor( ratio * $( window
).height() * 1.1 )
+ iiurlwidth: Math.floor( density * ratio * $(
window ).width() * 1.1 ),
+ iiurlheight: Math.floor( density * ratio * $(
window ).height() * 1.1 )
} ).done( function ( data ) {
var imageInfo, innerInfo,
image = new Image();
@@ -747,14 +748,15 @@
var imageInfo,
filename = fileTitle.getPrefixedText(),
ratio = this.lightbox.iface.isFullScreen ? 0.9 : 0.5,
+ density = $.devicePixelRatio(),
apiArgs = {
action: 'query',
format: 'json',
titles: filename,
prop: 'imageinfo',
iiprop: iiprops.join( '|' ),
- iiurlwidth: Math.floor( ratio * $( window
).width() * 1.1 ),
- iiurlheight: Math.floor( ratio * $( window
).height() * 1.1 ),
+ iiurlwidth: Math.floor( density * ratio * $(
window ).width() * 1.1 ),
+ iiurlheight: Math.floor( density * ratio * $(
window ).height() * 1.1 ),
// Short-circuit, don't fallback, to save some
tiny amount of time
iiextmetadatalanguage: mw.config.get(
'wgUserLanguage', false ) || mw.config.get( 'wgContentLanguage', 'en' )
},
--
To view, visit https://gerrit.wikimedia.org/r/93068
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d64d21ecc563486a6f7d4709cebc129ef77f930
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
