jenkins-bot has submitted this change and it was merged.
Change subject: Cleanup comments and whitespace
......................................................................
Cleanup comments and whitespace
Change-Id: I7597c590a59ada855d759615fbb1675c3bcfe461
---
M resources/js/ext.uls.displaysettings.js
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.displaysettings.js
b/resources/js/ext.uls.displaysettings.js
index b3d45ab..edb4483 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -141,6 +141,7 @@
$( '<p>' ).append(
$( '<span>' )
.addClass(
'uls-display-settings-anon-label' )
+ // .html() is
needed for correct parsing of the nbsp
.html( $.i18n(
'ext-uls-display-settings-anon-label' ) + ' ' ),
$( '<span>' )
.text( $.i18n(
'ext-uls-display-settings-anon-same-as-content', autonym ) )
@@ -152,7 +153,7 @@
.done( function ( parsedCta ) {
var deferred = new $.Deferred();
- $loginCta.html( parsedCta );
+ $loginCta.html( parsedCta ); //
The parsed CTA is HTML
$loginCta.find( 'a' ).click(
function ( event ) {
event.preventDefault();
// Because browsers
navigate away when clicking a link,
@@ -289,8 +290,8 @@
mw.uls.addEventLoggingTriggers();
if (
!displaySettings.$parent.$window.hasClass( 'callout' ) ) {
- // callout menus will have
position rules. others use
- // default position
+ // Callout menus will have
position rules.
+ // Others use the default
position.
return;
}
@@ -418,7 +419,9 @@
}
} );
- $systemFont = $( '<option>' ).val( 'system' ).text(
$.i18n( 'ext-uls-webfonts-system-font' ) );
+ $systemFont = $( '<option>' )
+ .val( 'system' )
+ .text( $.i18n( 'ext-uls-webfonts-system-font' )
);
$fontSelector.append( $systemFont );
$systemFont.attr( 'selected', savedFont === 'system' ||
!savedFont );
--
To view, visit https://gerrit.wikimedia.org/r/93062
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7597c590a59ada855d759615fbb1675c3bcfe461
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
