Ebrahim has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93079
Change subject: Native digits on $revsSince
......................................................................
Native digits on $revsSince
Change-Id: I017ec769180af8d06c547a2042ef459c6b2efe89
---
M frontend/FlaggablePageView.php
M frontend/FlaggedRevsXML.php
2 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/79/93079/1
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index 63de443..83a2b6a 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -469,7 +469,7 @@
if ( $this->showRatingIcon() ) {
$pending .= FlaggedRevsXML::draftStatusIcon();
}
- $pending .= $this->msg( 'revreview-edited',
$srev->getRevId(), $revsSince )->parse();
+ $pending .= $this->msg( 'revreview-edited',
$srev->getRevId() )->numParams( $revsSince )->parse();
$anchor = $request->getVal( 'fromsection' );
if ( $anchor != null ) {
// Hack: reverse some of the
Sanitizer::escapeId() encoding
@@ -495,12 +495,12 @@
$msg = $quality ?
'revreview-quick-quality-same' :
'revreview-quick-basic-same';
- $msgHTML = $this->msg( $msg,
$srev->getRevId(), $revsSince )->parse();
+ $msgHTML = $this->msg( $msg,
$srev->getRevId() )->numParams( $revsSince )->parse();
} else {
$msg = $quality ?
'revreview-quick-see-quality' :
'revreview-quick-see-basic';
- $msgHTML = $this->msg( $msg,
$srev->getRevId(), $revsSince )->parse();
+ $msgHTML = $this->msg( $msg,
$srev->getRevId() )->numParams( $revsSince )->parse();
}
$icon = '';
# For protection based configs, show lock only
if it's not redundant.
@@ -525,7 +525,7 @@
// Messages:
revreview-newest-quality-i, revreview-newest-basic-i
$msg .= ( $revsSince == 0 ) ? '-i' : '';
}
- $msgHTML = $this->msg( $msg, $srev->getRevId(),
$time, $revsSince )->parse();
+ $msgHTML = $this->msg( $msg, $srev->getRevId(),
$time )->numParams( $revsSince )->parse();
$icon = $synced ?
FlaggedRevsXML::stableStatusIcon(
$quality ) :
FlaggedRevsXML::draftStatusIcon();
@@ -569,7 +569,7 @@
$msg = $quality ?
'revreview-quick-quality-old' :
'revreview-quick-basic-old';
- $msgHTML = $this->msg( $msg,
$frev->getRevId(), $revsSince )->parse();
+ $msgHTML = $this->msg( $msg,
$frev->getRevId() )->numParams( $revsSince )->parse();
}
$msgHTML = $prot . $icon . $msgHTML;
$tag = FlaggedRevsXML::prettyRatingBox( $frev,
$msgHTML,
@@ -648,7 +648,7 @@
'revreview-quick-basic';
# Uses messages
'revreview-quick-quality-same', 'revreview-quick-basic-same'
$msg = $synced ? "{$msg}-same" : $msg;
- $msgHTML = $this->msg( $msg,
$srev->getRevId(), $revsSince )->parse();
+ $msgHTML = $this->msg( $msg,
$srev->getRevId() )->numParams( $revsSince )->parse();
}
$msgHTML = $prot . $icon . $msgHTML;
$tag = FlaggedRevsXML::prettyRatingBox( $srev,
$msgHTML,
@@ -665,7 +665,7 @@
$msg .= '-i';
}
$tag = $prot . $icon;
- $tag .= $this->msg( $msg, $srev->getRevId(),
$time, $revsSince )->parse();
+ $tag .= $this->msg( $msg, $srev->getRevId(),
$time )->numParams( $revsSince )->parse();
if ( !empty( $flags ) ) {
$tag .= FlaggedRevsXML::ratingToggle();
$tag .= "<div
id='mw-fr-revisiondetails'>" .
@@ -1073,7 +1073,7 @@
if ( $revsSince ) {
$s .= "<div class='flaggedrevs_editnotice
plainlinks'>" .
$this->msg(
'revreview-pending-nosection',
- $srev->getRevId(), $revsSince
)->parse() . "</div>";
+ $srev->getRevId() )->numParams(
$revsSince )->parse() . "</div>";
}
}
return true;
@@ -1413,7 +1413,7 @@
# Add bar msg to the top of the page...
$css = 'flaggedrevs_preview plainlinks';
// Messages: revreview-newest-quality-i,
revreview-newest-basic-i
- $msgHTML = $this->msg( $msg, $srev->getRevId(), $time,
$revsSince )->parse();
+ $msgHTML = $this->msg( $msg, $srev->getRevId(), $time
)->numParams( $revsSince )->parse();
$this->reviewNotice .= "<div id='mw-fr-reviewnotice'
class='$css'>" .
"$msgHTML$diffToggle</div>";
}
diff --git a/frontend/FlaggedRevsXML.php b/frontend/FlaggedRevsXML.php
index e34408c..08f25f1 100644
--- a/frontend/FlaggedRevsXML.php
+++ b/frontend/FlaggedRevsXML.php
@@ -262,7 +262,7 @@
if ( $synced && ( $type == 'stable' || $type == 'draft' ) ) {
$msg = $quality ?
'revreview-quality-same' :
'revreview-basic-same';
- $html = wfMessage( $msg, $frev->getRevId(), $time,
$revsSince )->parse();
+ $html = wfMessage( $msg, $frev->getRevId(), $time
)->numParams( $revsSince )->parse();
} elseif ( $type == 'oldstable' ) {
$msg = $quality ?
'revreview-quality-old' : 'revreview-basic-old';
@@ -278,7 +278,7 @@
# For searching: uses messages 'revreview-quality-i',
'revreview-basic-i',
# 'revreview-newest-quality-i',
'revreview-newest-basic-i'
$msg .= ( $revsSince == 0 ) ? '-i' : '';
- $html = wfMessage( $msg, $frev->getRevId(), $time,
$revsSince )->parse();
+ $html = wfMessage( $msg, $frev->getRevId(), $time
)->numParams( $revsSince )->parse();
}
# Make fancy box...
$box = '<div class="flaggedrevs_short_basic">';
@@ -420,7 +420,7 @@
* Creates "stable rev reviewed on"/"x pending edits" message
*/
public static function pendingEditNotice( $flaggedArticle, $frev,
$revsSince ) {
- $msg = self::pendingEditNoticeMessage( $flaggedArticle, $frev,
$revsSince );
+ $msg = self::pendingEditNoticeMessage( $flaggedArticle, $frev
)->numParams( $revsSince );
return $msg->parse();
}
--
To view, visit https://gerrit.wikimedia.org/r/93079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I017ec769180af8d06c547a2042ef459c6b2efe89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Ebrahim <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
