Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93156
Change subject: Remove unused parameter from testBooleanChange to fix warnings
......................................................................
Remove unused parameter from testBooleanChange to fix warnings
PHP Warning: Missing argument 3 for
CentralNoticeCampaignLogPager::testBooleanChange(), called in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 250 and defined in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 309
PHP Warning: Missing argument 3 for
CentralNoticeCampaignLogPager::testBooleanChange(), called in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 249 and defined in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 309
PHP Warning: Missing argument 3 for
CentralNoticeCampaignLogPager::testBooleanChange(), called in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 247 and defined in
/usr/local/apache/common-local/php-1.23wmf1/extensions/CentralNotice/CentralNoticeCampaignLogPager.php
on line 309
Change-Id: I61b0e08a02657b378f01166492726f20b5fc324d
---
M CentralNoticeCampaignLogPager.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/56/93156/1
diff --git a/CentralNoticeCampaignLogPager.php
b/CentralNoticeCampaignLogPager.php
index 0744633..166d1a0 100644
--- a/CentralNoticeCampaignLogPager.php
+++ b/CentralNoticeCampaignLogPager.php
@@ -303,10 +303,9 @@
/**
* @param $param
* @param $row
- * @param array $oldrow Required because this is a stupid heirarchy --
@see CentralNoticeBannerLogPager
* @return string
*/
- private function testBooleanChange( $param, $row, $oldrow ) {
+ private function testBooleanChange( $param, $row ) {
$result = '';
$beginField = 'notlog_begin_' . $param;
$endField = 'notlog_end_' . $param;
--
To view, visit https://gerrit.wikimedia.org/r/93156
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61b0e08a02657b378f01166492726f20b5fc324d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
