jenkins-bot has submitted this change and it was merged.
Change subject: ext.echo.alert: Restore orange background on Monobook
......................................................................
ext.echo.alert: Restore orange background on Monobook
Core styles for Monobook include high-specificity background: transparent;
rule for #p-personal li a, we need to match it to set our background.
Also change hover behavior: switch to a deeper orange instead of
default white, similarly to how the badge already behaves.
Partially reverts I682182fe.
Bug: 56214
Change-Id: I9f343264c395ecf09c1e34e03d208ec2119fb622
(cherry picked from commit dc1443f57f63e9f5c8609cd9450a6f074ad0078b)
---
M Echo.php
M modules/alert/ext.echo.alert.css
M modules/alert/ext.echo.alert.modern.css
A modules/alert/ext.echo.alert.monobook.css
4 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Echo.php b/Echo.php
index 080a239..87b1963 100644
--- a/Echo.php
+++ b/Echo.php
@@ -209,6 +209,7 @@
'styles' => 'alert/ext.echo.alert.css',
'skinStyles' => array(
'modern' => 'alert/ext.echo.alert.modern.css',
+ 'monobook' => 'alert/ext.echo.alert.monobook.css',
),
'messages' => array(
'echo-new-messages',
diff --git a/modules/alert/ext.echo.alert.css b/modules/alert/ext.echo.alert.css
index a1fb628..371730d 100644
--- a/modules/alert/ext.echo.alert.css
+++ b/modules/alert/ext.echo.alert.css
@@ -2,7 +2,8 @@
white-space: nowrap;
}
-.mw-echo-alert {
+/* High-specificity rule to override core styles for #p-personal li a */
+#pt-mytalk a.mw-echo-alert {
border-radius: 2px;
background-color: #F9C557;
padding: 0.25em 0.8em 0.2em 0.8em;
diff --git a/modules/alert/ext.echo.alert.modern.css
b/modules/alert/ext.echo.alert.modern.css
index 1a3786e..66e440b 100644
--- a/modules/alert/ext.echo.alert.modern.css
+++ b/modules/alert/ext.echo.alert.modern.css
@@ -1,4 +1,4 @@
-/* No rounded corners for modern skin */
-.mw-echo-alert {
+/* No rounded corners for Modern skin */
+#pt-mytalk a.mw-echo-alert {
border-radius: 0;
}
diff --git a/modules/alert/ext.echo.alert.monobook.css
b/modules/alert/ext.echo.alert.monobook.css
new file mode 100644
index 0000000..97ee676
--- /dev/null
+++ b/modules/alert/ext.echo.alert.monobook.css
@@ -0,0 +1,4 @@
+/* Different background color on hover for consistency with Monobook skin */
+#pt-mytalk a.mw-echo-alert:hover {
+ background-color: #FAB951;
+}
--
To view, visit https://gerrit.wikimedia.org/r/93305
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f343264c395ecf09c1e34e03d208ec2119fb622
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: REL1_22
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
