Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93480
Change subject: Fix appearance and messages on demo page
......................................................................
Fix appearance and messages on demo page
Some 've-ui-toolbar-bar' classes hadn't been converted to OO.ui so the
toolbar had no border. Also removed a useless rule in mw.ViewPageTarget.css.
SA platform didn't override OO.ui.msg to use the ve.msg so no messages
were getting through.
Change-Id: Ieb5bc3c98d1c435ec194b201b517a688cd9b02b9
---
M demos/ve/demo.css
M modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
M modules/ve/init/sa/ve.init.sa.Platform.js
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/80/93480/1
diff --git a/demos/ve/demo.css b/demos/ve/demo.css
index cea5b75..2fd9bf2 100644
--- a/demos/ve/demo.css
+++ b/demos/ve/demo.css
@@ -143,7 +143,7 @@
margin: 0 2em;
}
-.ve-init-sa-target-toolbar .ve-ui-toolbar-bar {
+.ve-init-sa-target-toolbar .oo-ui-toolbar-bar {
border: solid 1px #ccc;
border-radius: 0;
-webkit-border-top-right-radius: 0.25em;
@@ -156,7 +156,7 @@
border-top-left-radius: 0.25em;
}
-.ve-init-sa-target-toolbar.ve-ui-toolbar-floating .ve-ui-toolbar-bar {
+.ve-init-sa-target-toolbar.ve-ui-toolbar-floating .oo-ui-toolbar-bar {
border-top: none;
border-radius: 0;
}
diff --git a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
index 4002375..bf5935d 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.ViewPageTarget.css
@@ -46,10 +46,6 @@
padding: 0.25em;
}
-.ve-init-mw-viewPageTarget-toolbar-utilites .ve-ui-toolbar-bar {
- border: none;
-}
-
.ve-init-mw-viewPageTarget-toolbar-utilites > .oo-ui-iconButtonWidget {
margin-right: 0.2em;
margin-top: 0.2em;
diff --git a/modules/ve/init/sa/ve.init.sa.Platform.js
b/modules/ve/init/sa/ve.init.sa.Platform.js
index 4c70884..947f1bf 100644
--- a/modules/ve/init/sa/ve.init.sa.Platform.js
+++ b/modules/ve/init/sa/ve.init.sa.Platform.js
@@ -125,3 +125,7 @@
/* Initialization */
ve.init.platform = new ve.init.sa.Platform();
+
+/* Extension */
+
+OO.ui.msg = ve.bind( ve.init.platform.getMessage, ve.init.platform );
--
To view, visit https://gerrit.wikimedia.org/r/93480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb5bc3c98d1c435ec194b201b517a688cd9b02b9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
