Amire80 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/93518


Change subject: Set explicit direction for wb-entity-undefinedinfo
......................................................................

Set explicit direction for wb-entity-undefinedinfo

This element is included in <div dir="auto">, but it is
supposed to be shown in the user's language, so the direction
must be explicitly set.

Change-Id: I49b1149f482696cfc0a58e6c39de0a4b22d5a256
---
M lib/resources/wikibase.utilities/wikibase.utilities.ui.js
1 file changed, 7 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/18/93518/1

diff --git a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js 
b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
index 1e7bdaa..38dd2c0 100644
--- a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
+++ b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js
@@ -69,6 +69,7 @@
                        }
                        var $undefinedInfo = $( '<span/>', {
                                'class': 'wb-entity-undefinedinfo',
+                               'dir': IS_RTL ? 'rtl' : 'ltr',
                                'text': mw.msg( 'parentheses', mw.msg( 
'wikibase-label-empty' ) )
                        } );
                        $label = $label.add( $undefinedInfo );
@@ -92,9 +93,12 @@
                entityType = typeof entityType === 'string' ? entityType : 
entityType.TYPE;
 
                return $( '<span/>' ).text( entityId + SPACE ).append(
-                       $( '<span>', { 'class': 'wb-entity-undefinedinfo' } 
).text(
-                               mw.msg( 'parentheses',
-                                       mw.msg( 'wikibase-deletedentity-' + 
entityType ) ) ) );
+                       $( '<span>', {
+                               'class': 'wb-entity-undefinedinfo',
+                               'dir': IS_RTL ? 'rtl' : 'ltr',
+                               'text': mw.msg( 'parentheses', mw.msg( 
'wikibase-deletedentity-' + entityType ) )
+                       } )
+               );
        };
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/93518
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49b1149f482696cfc0a58e6c39de0a4b22d5a256
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to