CSteipp has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93521
Change subject: Remove redaction handling
......................................................................
Remove redaction handling
Since I3d570a6385f96a606e1af53c50faa03b9ebacd38, this is no longer used
and causes exceptions.
Change-Id: Idc35b36b4baa7f8979077c325ee29dea391f61c5
---
M OAuth.php
M OAuth.setup.php
2 files changed, 2 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth
refs/changes/21/93521/1
diff --git a/OAuth.php b/OAuth.php
index cccdd03..a0deb37 100644
--- a/OAuth.php
+++ b/OAuth.php
@@ -36,9 +36,7 @@
# Define were PHP files and i18n files are located
require( __DIR__ . '/OAuth.setup.php' );
-MWOAuthSetup::defineSourcePaths(
- $wgAutoloadClasses, $wgExtensionMessagesFiles,
$wgRedactedFunctionArguments
-);
+MWOAuthSetup::defineSourcePaths( $wgAutoloadClasses, $wgExtensionMessagesFiles
);
# Setup steps that does not depend on configuration
MWOAuthSetup::unconditionalSetup();
diff --git a/OAuth.setup.php b/OAuth.setup.php
index f032782..4db51a9 100644
--- a/OAuth.setup.php
+++ b/OAuth.setup.php
@@ -12,9 +12,7 @@
* @param $redactedFunctionArgs Array $redactedFunctionArgs
* @return void
*/
- public static function defineSourcePaths(
- array &$classes, array &$messagesFiles, array
&$redactedFunctionArgs
- ) {
+ public static function defineSourcePaths( array &$classes, array
&$messagesFiles ) {
$dir = __DIR__;
# Basic directory layout
@@ -84,18 +82,6 @@
# Schema changes
$classes['MWOAuthUpdaterHooks'] =
"$schemaDir/MWOAuthUpdater.hooks.php";
-
- # Indicate functions with arguments that need redaction
- $redactedFunctionArgs += array(
- 'MWOAuthDAO::setField' => 1, # $value could be a secret
- 'MWOAuthUtils::hmacDBSecret' => 0,
- 'OAuthConsumer::__construct' => 1,
- 'OAuthToken::__construct' => 1,
- 'OAuthRequest::set_parameter' => 1, # $value could be
the nonce
- 'OAuthServer::check_nonce' => 2,
- 'OAuthDataStore::lookup_nonce' => 2,
- 'OAuthUtil::urlencode_rfc3986' => 0, # Value being
encoded may contain secrets
- );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/93521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc35b36b4baa7f8979077c325ee29dea391f61c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: CSteipp <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
