MaxSem has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/93589


Change subject: Tweak main file
......................................................................

Tweak main file

* Order variables properly
* Make it possible to override LESS variables
* Unset $cwd ASAP

Change-Id: Ifde743a5cbd203360f424fc19b9717e9e99224db
---
M MobileFrontend.php
1 file changed, 18 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/89/93589/1

diff --git a/MobileFrontend.php b/MobileFrontend.php
index d4bac31..d629bc2 100644
--- a/MobileFrontend.php
+++ b/MobileFrontend.php
@@ -94,6 +94,8 @@
        $wgAutoloadClasses[$className] = "$cwd/includes/$classFilename.php";
 }
 
+unset( $cwd );
+
 $wgExtensionFunctions[] = 'efMobileFrontend_Setup';
 
 $wgAPIPropModules['extracts'] = 'ApiQueryExtracts';
@@ -138,24 +140,20 @@
 $wgSpecialPages['MobileMenu'] = 'SpecialMobileMenu';
 
 function efMobileFrontend_Setup() {
-       global $wgMFNearby, $wgSpecialPages, $wgSpecialPageGroups;
+       global $wgMFNearby, $wgSpecialPages, $wgSpecialPageGroups, 
$wgResourceLoaderLESSVars,
+               $wgMFDeviceWidthTablet, $wgMFDeviceWidthMobileSmall;
 
        if ( $wgMFNearby ) {
                $wgSpecialPages['Nearby'] = 'SpecialNearby';
                $wgSpecialPageGroups['Nearby'] = 'pages';
        }
+       // Set LESS global variables
+       $wgResourceLoaderLESSVars['wgMFDeviceWidthTablet'] = 
"{$wgMFDeviceWidthTablet}px";
+       $wgResourceLoaderLESSVars['wgMFDeviceWidthMobileSmall'] = 
"{$wgMFDeviceWidthMobileSmall}px";
 }
 
 // ResourceLoader modules
 require_once( "$cwd/includes/Resources.php" );
-
-$wgMFDeviceWidthTablet = 768;
-
-// Set LESS global variables
-$wgResourceLoaderLESSVars['wgMFDeviceWidthTablet'] = $wgMFDeviceWidthTablet . 
'px';
-$wgResourceLoaderLESSVars['wgMFDeviceWidthMobileSmall'] = '280px';
-
-unset( $cwd );
 
 /**
  * Begin configuration variables
@@ -415,3 +413,14 @@
  * @var bool
  */
 $wgMFAjaxUploadProgressSupport = false;
+
+/**
+ * Minimum available screen width at which a device can be considered a 
tablet/desktop
+ */
+$wgMFDeviceWidthTablet = 768;
+
+/**
+ * Devices with available screen of this value and less will have some styles 
adapted for improved reading
+ * on small screens
+ */
+$wgMFDeviceWidthMobileSmall = 280;

-- 
To view, visit https://gerrit.wikimedia.org/r/93589
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifde743a5cbd203360f424fc19b9717e9e99224db
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MaxSem <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to