Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93616
Change subject: Invalid argument supplied for foreach() in FormatMetadata.php
on line 1566
......................................................................
Invalid argument supplied for foreach() in FormatMetadata.php on line 1566
Bug: 56585
Change-Id: I5f65333cc94b66fd80fcf5abcfad7e10e4669310
---
M includes/media/FormatMetadata.php
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/16/93616/1
diff --git a/includes/media/FormatMetadata.php
b/includes/media/FormatMetadata.php
index b34ad65..91c4c9a 100755
--- a/includes/media/FormatMetadata.php
+++ b/includes/media/FormatMetadata.php
@@ -1563,11 +1563,13 @@
$common = $file->getCommonMetaArray();
- foreach ( $common as $key => $value ) {
- $fileMetadata[$key] = array(
- 'value' => $value,
- 'source' => 'file-metadata',
- );
+ if ( $common !== false ) {
+ foreach ( $common as $key => $value ) {
+ $fileMetadata[$key] = array(
+ 'value' => $value,
+ 'source' => 'file-metadata',
+ );
+ }
}
wfProfileOut( __METHOD__ );
--
To view, visit https://gerrit.wikimedia.org/r/93616
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f65333cc94b66fd80fcf5abcfad7e10e4669310
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
