Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93679
Change subject: Fix more missing use statements in /api
......................................................................
Fix more missing use statements in /api
Change-Id: I3f4423297a3249a19db6acb75ecab20c1efa83a6
---
M repo/includes/api/ClaimModificationHelper.php
M repo/includes/api/EditEntity.php
M repo/includes/api/GetEntities.php
M repo/includes/api/ModifyEntity.php
M repo/includes/api/RemoveClaims.php
M repo/includes/api/RemoveQualifiers.php
M repo/includes/api/RemoveReferences.php
M repo/includes/api/SetAliases.php
8 files changed, 14 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/79/93679/1
diff --git a/repo/includes/api/ClaimModificationHelper.php
b/repo/includes/api/ClaimModificationHelper.php
index 05ee09e..4da215b 100644
--- a/repo/includes/api/ClaimModificationHelper.php
+++ b/repo/includes/api/ClaimModificationHelper.php
@@ -238,10 +238,11 @@
* @since 0.4
*
* @param array $params
+ * @param ApiBase $module
*
* @return Summary
*/
- public function createSummary( array $params, \ApiBase $module ) {
+ public function createSummary( array $params, ApiBase $module ) {
$summary = new Summary( $module->getModuleName() );
if ( isset( $params['summary'] ) ) {
$summary->setUserSummary( $params['summary'] );
diff --git a/repo/includes/api/EditEntity.php b/repo/includes/api/EditEntity.php
index 3d05727..2d69781 100644
--- a/repo/includes/api/EditEntity.php
+++ b/repo/includes/api/EditEntity.php
@@ -9,7 +9,6 @@
use Revision;
use SiteList;
use Title;
-use User;
use Wikibase\ChangeOp\ChangeOp;
use Wikibase\ChangeOp\ChangeOpAliases;
use Wikibase\ChangeOp\ChangeOpClaim;
@@ -22,12 +21,10 @@
use Wikibase\Claim;
use Wikibase\Entity;
use Wikibase\EntityContent;
-use Wikibase\EntityContentFactory;
use Wikibase\Item;
use Wikibase\Lib\ClaimGuidGenerator;
use Wikibase\Lib\Serializers\SerializerFactory;
use Wikibase\Property;
-use Wikibase\QueryContent;
use Wikibase\Repo\WikibaseRepo;
use Wikibase\Summary;
use Wikibase\Utils;
diff --git a/repo/includes/api/GetEntities.php
b/repo/includes/api/GetEntities.php
index 4e947e9..3b58fd0 100644
--- a/repo/includes/api/GetEntities.php
+++ b/repo/includes/api/GetEntities.php
@@ -5,7 +5,9 @@
use ApiBase;
use SiteSQLStore;
use MWException;
+use ValueParsers\ParseException;
use Wikibase\DataModel\Entity\EntityId;
+use Wikibase\EntityContent;
use Wikibase\Lib\Serializers\SerializationOptions;
use Wikibase\Lib\Serializers\EntitySerializer;
use Wikibase\Lib\Serializers\SerializerFactory;
@@ -150,7 +152,7 @@
$id = $this->entityIdParser->parse( $entityId );
$ids[] = $id->getPrefixedId();
}
- catch ( \ValueParsers\ParseException $parseException ) {
+ catch ( ParseException $parseException ) {
// This will error below
$ids[] = null;
}
@@ -181,7 +183,7 @@
try {
$entityId = $entityIdParser->parse( $id );
- } catch( \ValueParsers\ParseException $e ) {
+ } catch( ParseException $e ) {
wfProfileOut( __METHOD__ );
$this->dieUsage( "Invalid id: $id", 'no-such-entity' );
}
@@ -202,7 +204,7 @@
// as long as getWikiPageForId only returns ids
for legal items this holds
/**
- * @var $entityContent \Wikibase\EntityContent
+ * @var $entityContent EntityContent
*/
$entityContent = $page->getContent();
diff --git a/repo/includes/api/ModifyEntity.php
b/repo/includes/api/ModifyEntity.php
index 79740e5..3438166 100644
--- a/repo/includes/api/ModifyEntity.php
+++ b/repo/includes/api/ModifyEntity.php
@@ -4,6 +4,7 @@
use Status, User, Title;
use ApiBase;
+use ValueParsers\ParseException;
use Wikibase\EntityContent;
use Wikibase\EntityContentFactory;
use Wikibase\ItemHandler;
@@ -74,7 +75,7 @@
try{
$entityId =
WikibaseRepo::getDefaultInstance()->getEntityIdParser()->parse( $id );
- } catch( \ValueParsers\ParseException $e ){
+ } catch( ParseException $e ){
$this->dieUsage( "Could not parse {$id}, No
entity found", 'no-such-entity-id' );
}
diff --git a/repo/includes/api/RemoveClaims.php
b/repo/includes/api/RemoveClaims.php
index 15cfbc5..00b0c43 100644
--- a/repo/includes/api/RemoveClaims.php
+++ b/repo/includes/api/RemoveClaims.php
@@ -3,6 +3,7 @@
namespace Wikibase\Api;
use ApiBase;
+use Wikibase\ChangeOp\ChangeOp;
use Wikibase\Claims;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\Entity;
diff --git a/repo/includes/api/RemoveQualifiers.php
b/repo/includes/api/RemoveQualifiers.php
index 2c3e42a..956417a 100644
--- a/repo/includes/api/RemoveQualifiers.php
+++ b/repo/includes/api/RemoveQualifiers.php
@@ -3,6 +3,7 @@
namespace Wikibase\Api;
use ApiBase;
+use Wikibase\ChangeOp\ChangeOp;
use Wikibase\Claim;
use Wikibase\Repo\WikibaseRepo;
use Wikibase\ChangeOp\ChangeOpQualifier;
diff --git a/repo/includes/api/RemoveReferences.php
b/repo/includes/api/RemoveReferences.php
index 94699a6..e102edc 100644
--- a/repo/includes/api/RemoveReferences.php
+++ b/repo/includes/api/RemoveReferences.php
@@ -3,6 +3,7 @@
namespace Wikibase\Api;
use ApiBase;
+use Wikibase\ChangeOp\ChangeOp;
use Wikibase\Statement;
use Wikibase\Repo\WikibaseRepo;
use Wikibase\ChangeOp\ChangeOpReference;
diff --git a/repo/includes/api/SetAliases.php b/repo/includes/api/SetAliases.php
index 4a8afe8..008cd0e 100644
--- a/repo/includes/api/SetAliases.php
+++ b/repo/includes/api/SetAliases.php
@@ -2,6 +2,7 @@
namespace Wikibase\Api;
+use Wikibase\ChangeOp\ChangeOp;
use Wikibase\ChangeOp\ChangeOpException;
use Wikibase\ChangeOp\ChangeOps;
use ApiBase, User, Language;
@@ -67,6 +68,7 @@
$entity = $entityContent->getEntity();
$language = $params['language'];
+ /** @var ChangeOp[] $aliasesChangeOps */
$aliasesChangeOps = $this->getChangeOps( $params );
try{
--
To view, visit https://gerrit.wikimedia.org/r/93679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f4423297a3249a19db6acb75ecab20c1efa83a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
