Yaron Koren has submitted this change and it was merged.
Change subject: Simplified display of fields in "Edit schema", added "minor
field" display
......................................................................
Simplified display of fields in "Edit schema", added "minor field" display
Change-Id: Iae1457e1f6c85a1dbed1f5c73a8f53b98c987910
---
M includes/SD_PageSchemas.php
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Yaron Koren: Verified; Looks good to me, approved
diff --git a/includes/SD_PageSchemas.php b/includes/SD_PageSchemas.php
index 78c2228..6357409 100644
--- a/includes/SD_PageSchemas.php
+++ b/includes/SD_PageSchemas.php
@@ -88,12 +88,12 @@
$usePropertyValuesAttr['checked'] = true;
}
- $html_text = '<p>' . wfMsg( 'ps-optional-name' ) . ' ';
+ $html_text = '<div class="editSchemaMinorFields">' . "\n";
+ $html_text .= '<p>' . wfMsg( 'ps-optional-name' ) . ' ';
$html_text .= Html::input( 'sd_filter_name_num', $filterName,
'text', array( 'size' => 25 ) ) . "</p>\n";
- $html_text .= '<fieldset><legend>' . wfMsg(
'sd-pageschemas-values' ) . '</legend>' . "\n";
- $html_text .= '<p>' . Html::input( 'sd_values_source_num',
'property', 'radio', $usePropertyValuesAttr ) . ' ';
- $html_text .= wfMsg( 'sd_createfilter_usepropertyvalues' ) .
"</p>\n";
- $html_text .= "\t<p>\n";
+ $html_text .= wfMsg( 'sd-pageschemas-values' ) . ":\n";
+ $html_text .= Html::input( 'sd_values_source_num', 'property',
'radio', $usePropertyValuesAttr ) . ' ';
+ $html_text .= wfMsg( 'sd_createfilter_usepropertyvalues' ) .
"\n";
$html_text .= Html::input( 'sd_values_source_num', 'category',
'radio', $fromCategoryAttrs ) . "\n";
$html_text .= "\t" . wfMsg( 'sd_createfilter_usecategoryvalues'
) . "\n";
$categories = SDUtils::getTopLevelCategories();
@@ -108,6 +108,7 @@
}
$html_text .= "\t" . Html::rawElement( 'select', array( 'id' =>
'category_dropdown', 'name' => 'sd_category_name_num' ), "\n" . $categoriesHTML
) . "\n";
$html_text .= "\t</p>\n";
+ $html_text .= "\t</div>\n";
return array( $html_text, $hasExistingValues );
}
--
To view, visit https://gerrit.wikimedia.org/r/93706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iae1457e1f6c85a1dbed1f5c73a8f53b98c987910
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticDrilldown
Gerrit-Branch: master
Gerrit-Owner: Yaron Koren <[email protected]>
Gerrit-Reviewer: Yaron Koren <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
