Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93741
Change subject: Adding output writer parameters to jmxtrans::metrics::jvm
......................................................................
Adding output writer parameters to jmxtrans::metrics::jvm
Change-Id: I6bfa62f4334882510f329f987b31eeec171a5b28
---
M manifests/metrics/jvm.pp
1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/jmxtrans
refs/changes/41/93741/1
diff --git a/manifests/metrics/jvm.pp b/manifests/metrics/jvm.pp
index d6d8481..65aa522 100644
--- a/manifests/metrics/jvm.pp
+++ b/manifests/metrics/jvm.pp
@@ -6,11 +6,24 @@
#
# == Parameters
# $title - host:port of JMX to query (required)
-define jmxtrans::metrics::jvm() {
+# $ganglia - $ganglia parameter to pass to jmxtrans::metrics
+# $graphite - $graphite parameter to pass to jmxtrans::metrics
+# $outfile - $outfile parameter to pass to jmxtrans::metrics
+#
+define jmxtrans::metrics::jvm(
+ $ganglia = undef,
+ $graphite = undef,
+ $outfile = undef,
+)
+{
jmxtrans::metrics { "${title}-jvm-metrics":
- jmx => "$title",
- ganglia_group_name => 'jvm_memory',
- objects => [
+ jmx => "$title",
+ outfile => $outfile,
+ ganglia => $ganglia,
+ ganglia_group_name => 'jvm_memory',
+ graphite => $graphite,
+ graphite_root_prefix => 'jvm_memory',
+ objects => [
{
'name' => 'java.lang:type=Memory',
'resultAlias' => 'memory',
--
To view, visit https://gerrit.wikimedia.org/r/93741
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bfa62f4334882510f329f987b31eeec171a5b28
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/jmxtrans
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
