jenkins-bot has submitted this change and it was merged.
Change subject: header editing is broken for headers created by anon users
......................................................................
header editing is broken for headers created by anon users
Fatal error: Call to a member function getName() on a non-object
in /Flow/includes/Block/Topic.php on line 533
This is mainly because User::newFromName() would fail on IPs by default
Change-Id: I8df80b0a959cd7acfafa091ca89d98ad6cf952af
---
M includes/Block/Topic.php
M includes/Model/PostRevision.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Block/Topic.php b/includes/Block/Topic.php
index c7b7f44..3ca66f4 100644
--- a/includes/Block/Topic.php
+++ b/includes/Block/Topic.php
@@ -530,7 +530,7 @@
'*' => $post->getContent( null, $contentFormat
),
'format' => $contentFormat
);
- $output['user'] = $post->getCreator()->getName();
+ $output['user'] = $post->getCreatorName();
}
if ( ! isset( $options['no-children'] ) ) {
diff --git a/includes/Model/PostRevision.php b/includes/Model/PostRevision.php
index 7772838..c436759 100644
--- a/includes/Model/PostRevision.php
+++ b/includes/Model/PostRevision.php
@@ -130,7 +130,7 @@
if ( $this->getCreatorIdRaw() !== 0 ) {
$user = User::newFromId(
$this->getCreatorIdRaw() );
} else {
- $user = User::newFromName(
$this->getCreatorNameRaw() );
+ $user = User::newFromName(
$this->getCreatorNameRaw(), false );
}
return $user;
--
To view, visit https://gerrit.wikimedia.org/r/93868
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8df80b0a959cd7acfafa091ca89d98ad6cf952af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
