jenkins-bot has submitted this change and it was merged.
Change subject: Make sure all links have target=_blank in the save dialog
......................................................................
Make sure all links have target=_blank in the save dialog
Anything that uses getParsedMessage could contain a link.
Change-Id: I523edd935c4989e5929fca8891651c2287af973a
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
2 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 208f0d1..55459c5 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -506,7 +506,7 @@
$( '<strong>' ).text( mw.msg(
'captcha-label' ) ),
document.createTextNode( mw.msg(
'colon-separator' ) ),
$( $.parseHTML( mw.message(
'fancycaptcha-edit' ).parse() ) )
- .filter( 'a' ).attr( 'target',
'_blank ' ).end()
+ .filter( 'a' ).attr( 'target',
'_blank' ).end()
),
$( '<img>' ).attr( 'src', editApi.captcha.url ),
this.captcha.input.$element
@@ -697,7 +697,7 @@
if ( text.match( /\[\[|\{\{|''|<nowiki|~~~|^==|^\*|^\#/ ) ) {
mw.notify(
$( $.parseHTML( ve.init.platform.getParsedMessage(
'visualeditor-wikitext-warning' ) ) )
- .filter( 'a' ).attr( 'target', '_blank '
).end(),
+ .filter( 'a' ).attr( 'target', '_blank' ).end(),
{
'title': ve.msg(
'visualeditor-wikitext-warning-title' ),
'tag': 'visualeditor-wikitext-warning',
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
index 8a92ffd..82fdc4f 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWSaveDialog.js
@@ -56,7 +56,8 @@
// Save panel
this.$editSummaryLabel = this.$( '<div>' ).addClass(
've-ui-mwSaveDialog-summaryLabel' )
- .html( ve.init.platform.getParsedMessage( 'summary' ) );
+ .html( ve.init.platform.getParsedMessage( 'summary' ) )
+ .find( 'a' ).attr( 'target', '_blank' ).end();
this.editSummaryInput = new OO.ui.TextInputWidget(
{ '$': this.$, 'multiline': true, 'placeholder': ve.msg(
'visualeditor-editsummary' ) }
);
@@ -90,7 +91,9 @@
this.$saveFoot = this.$( '<div>' ).addClass( 've-ui-mwSaveDialog-foot'
).append(
this.$( '<p>' ).addClass( 've-ui-mwSaveDialog-license' )
.html( ve.init.platform.getParsedMessage(
'copyrightwarning' ) )
+ .find( 'a' ).attr( 'target', '_blank' ).end()
);
+
this.savePanel.$element.append(
this.$editSummaryLabel,
this.editSummaryInput.$element,
@@ -109,13 +112,15 @@
// Conflict panel
this.conflictPanel = new OO.ui.PanelLayout( { '$': this.$,
'scrollable': true } );
this.$conflict = this.$( '<div>' ).addClass(
've-ui-mwSaveDialog-conflict' )
- .html( ve.init.platform.getParsedMessage(
'visualeditor-editconflict' ) );
+ .html( ve.init.platform.getParsedMessage(
'visualeditor-editconflict' ) )
+ .find( 'a' ).attr( 'target', '_blank' ).end();
this.conflictPanel.$element.append( this.$conflict );
// No changes panel
this.nochangesPanel = new OO.ui.PanelLayout( { '$': this.$,
'scrollable': true } );
this.$noChanges = this.$( '<div>' ).addClass(
've-ui-mwSaveDialog-nochanges' )
- .html( ve.init.platform.getParsedMessage(
'visualeditor-diff-nochanges' ) );
+ .html( ve.init.platform.getParsedMessage(
'visualeditor-diff-nochanges' ) )
+ .find( 'a' ).attr( 'target', '_blank' ).end();
this.nochangesPanel.$element.append( this.$noChanges );
// Panel stack
--
To view, visit https://gerrit.wikimedia.org/r/93749
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I523edd935c4989e5929fca8891651c2287af973a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
