jenkins-bot has submitted this change and it was merged.

Change subject: Make "Show history" tab display as selected when on Flow board
......................................................................


Make "Show history" tab display as selected when on Flow board

Change-Id: Ic066d9860482bbef6f1c8da4090192421ba5d8ea
---
M Hooks.php
1 file changed, 3 insertions(+), 5 deletions(-)

Approvals:
  Werdna: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Hooks.php b/Hooks.php
index 4fbfe91..9fd3cf9 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -195,8 +195,10 @@
                if ( $occupationController->isTalkpageOccupied( $title ) ) {
                        $skname = $template->skinname;
 
+                       global $wgRequest;
+                       $selected = $wgRequest->getVal( 'action' ) == 
'board-history';
                        $links['views'] = array( array(
-                               'class' => false,
+                               'class' => $selected ? 'selected' : '',
                                'text' => wfMessageFallback( 
"$skname-view-history", "history_short" )->text(),
                                'href' => $title->getLocalURL( 
'action=board-history' ),
                        ) );
@@ -208,10 +210,6 @@
                                $links['actions']['move'],
                                $links['actions']['undelete']
                        );
-
-                       // @todo: at some point, we'll probably want to 
re-use/override:
-                       // - ['views']['history']
-                       // - ['actions']['protect'] & ['actions']['unprotect']
                }
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/93689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic066d9860482bbef6f1c8da4090192421ba5d8ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to