Brion VIBBER has submitted this change and it was merged.

Change subject: Add custom animation when navigating to a new page
......................................................................


Add custom animation when navigating to a new page

Old pages slide out to the left, new ones slide in from the
right. Works when going back too.

Change-Id: I9b6eb07dc1456db6bbc7a10aa0717782fbead0ed
---
A wikipedia/res/anim/slide_in_left.xml
A wikipedia/res/anim/slide_in_right.xml
A wikipedia/res/anim/slide_out_left.xml
A wikipedia/res/anim/slide_out_right.xml
M wikipedia/src/main/java/org/wikimedia/wikipedia/PageActivity.java
5 files changed, 33 insertions(+), 0 deletions(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/wikipedia/res/anim/slide_in_left.xml 
b/wikipedia/res/anim/slide_in_left.xml
new file mode 100644
index 0000000..5ecb47f
--- /dev/null
+++ b/wikipedia/res/anim/slide_in_left.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set>
+    <translate xmlns:android="http://schemas.android.com/apk/res/android";
+               android:fromXDelta="-100%"
+               android:toXDelta="0"
+               android:interpolator="@android:anim/accelerate_interpolator"
+               android:duration="@android:integer/config_shortAnimTime"/>
+</set>
diff --git a/wikipedia/res/anim/slide_in_right.xml 
b/wikipedia/res/anim/slide_in_right.xml
new file mode 100644
index 0000000..048c5a4
--- /dev/null
+++ b/wikipedia/res/anim/slide_in_right.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set>
+    <translate xmlns:android="http://schemas.android.com/apk/res/android";
+               android:fromXDelta="100%"
+               android:toXDelta="0"
+               android:interpolator="@android:anim/accelerate_interpolator"
+               android:duration="@android:integer/config_shortAnimTime"/>
+</set>
diff --git a/wikipedia/res/anim/slide_out_left.xml 
b/wikipedia/res/anim/slide_out_left.xml
new file mode 100644
index 0000000..2e3f8ce
--- /dev/null
+++ b/wikipedia/res/anim/slide_out_left.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set>
+    <translate xmlns:android="http://schemas.android.com/apk/res/android";
+               android:fromXDelta="0"
+               android:toXDelta="-100%"
+               android:interpolator="@android:anim/accelerate_interpolator"
+               android:duration="@android:integer/config_shortAnimTime"/>
+</set>
diff --git a/wikipedia/res/anim/slide_out_right.xml 
b/wikipedia/res/anim/slide_out_right.xml
new file mode 100644
index 0000000..ccd6fee
--- /dev/null
+++ b/wikipedia/res/anim/slide_out_right.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set>
+    <translate xmlns:android="http://schemas.android.com/apk/res/android";
+               android:fromXDelta="0"
+               android:toXDelta="+100%"
+               android:interpolator="@android:anim/accelerate_interpolator"
+               android:duration="@android:integer/config_shortAnimTime"/>
+</set>
diff --git a/wikipedia/src/main/java/org/wikimedia/wikipedia/PageActivity.java 
b/wikipedia/src/main/java/org/wikimedia/wikipedia/PageActivity.java
index 9f30cd8..9783f25 100644
--- a/wikipedia/src/main/java/org/wikimedia/wikipedia/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikimedia/wikipedia/PageActivity.java
@@ -39,6 +39,7 @@
     private void displayNewPage(PageTitle title) {
         PageViewFragment pageFragment = new PageViewFragment(title);
         getSupportFragmentManager().beginTransaction()
+                .setCustomAnimations(R.anim.slide_in_right, 
R.anim.slide_out_left, R.anim.slide_in_left, R.anim.slide_out_right)
                 .replace(R.id.content_frame, pageFragment)
                 .addToBackStack(null)
                 .commit();

-- 
To view, visit https://gerrit.wikimedia.org/r/93913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9b6eb07dc1456db6bbc7a10aa0717782fbead0ed
Gerrit-PatchSet: 4
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to