Werdna has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94073
Change subject: Improve failure case for MutliDimArray
......................................................................
Improve failure case for MutliDimArray
Throw an exception instead of an obscure reference error
Change-Id: Ia9c5496964b51d45eed6a30896633a9e67257b27
---
M includes/Data/MultiDimArray.php
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/73/94073/1
diff --git a/includes/Data/MultiDimArray.php b/includes/Data/MultiDimArray.php
index 5a962da..1735f03 100644
--- a/includes/Data/MultiDimArray.php
+++ b/includes/Data/MultiDimArray.php
@@ -55,6 +55,8 @@
foreach ( (array) $offset as $key ) {
if ( !isset( $data[$key] ) ) {
throw new \OutOfBoundsException( 'Does not
exist' );
+ } elseif ( ! is_array( $data ) ) {
+ throw new \MWException( "Requested offset
{$key} (full offset ".implode(':', $offset)."), but $data is not an array." );
}
$data =& $data[$key];
}
--
To view, visit https://gerrit.wikimedia.org/r/94073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9c5496964b51d45eed6a30896633a9e67257b27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Werdna <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
