jenkins-bot has submitted this change and it was merged.

Change subject: Make clicks on "Yes" for Desktop interstitial redirect properly.
......................................................................


Make clicks on "Yes" for Desktop interstitial redirect properly.

* For bug 52536.

Change-Id: I26019c354e5e561f774f9c350324fc0411876393
---
M includes/PageRenderingHooks.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  CSteipp: Looks good to me, but someone else must approve
  Yurik: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/PageRenderingHooks.php b/includes/PageRenderingHooks.php
index c93293f..9af14ce 100644
--- a/includes/PageRenderingHooks.php
+++ b/includes/PageRenderingHooks.php
@@ -935,7 +935,8 @@
                                $ch1 = substr( $href, 1, 1 );
                                // Local links start with either '#...', '?...' 
or '/...', but not '//...'
                                if ( $ch0 !== '#' && $ch0 !== '?' && ( $ch0 !== 
'/' || $ch1 === '/' ) ) {
-                                       return 'href=' . $quoteChar . 
$self->makeRedirect( $href ) . $quoteChar ;
+                                       return 'href=' .
+                                               $quoteChar . 
$self->makeRedirect( htmlspecialchars_decode( $href ) ) . $quoteChar;
                                } else {
                                        return $matches[0];
                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/93893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26019c354e5e561f774f9c350324fc0411876393
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: Yurik <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to