jenkins-bot has submitted this change and it was merged.
Change subject: Break long lines
......................................................................
Break long lines
Fixes CodeSniffer errors/warnings.
Change-Id: I6417072270ec7236ad2412abda6f6afce189f0fd
---
M tests/phpunit/includes/utils/IPTest.php
1 file changed, 20 insertions(+), 5 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/utils/IPTest.php
b/tests/phpunit/includes/utils/IPTest.php
index c074eea..24b077a 100644
--- a/tests/phpunit/includes/utils/IPTest.php
+++ b/tests/phpunit/includes/utils/IPTest.php
@@ -21,8 +21,14 @@
$this->assertFalse( IP::isIPAddress( 'abc' ), 'Garbage IP
string' );
$this->assertFalse( IP::isIPAddress( ':' ), 'Single ":" is not
an IP' );
$this->assertFalse( IP::isIPAddress( '2001:0DB8::A:1::1' ),
'IPv6 with a double :: occurrence' );
- $this->assertFalse( IP::isIPAddress( '2001:0DB8::A:1::' ),
'IPv6 with a double :: occurrence, last at end' );
- $this->assertFalse( IP::isIPAddress( '::2001:0DB8::5:1' ),
'IPv6 with a double :: occurrence, firt at beginning' );
+ $this->assertFalse(
+ IP::isIPAddress( '2001:0DB8::A:1::' ),
+ 'IPv6 with a double :: occurrence, last at end'
+ );
+ $this->assertFalse(
+ IP::isIPAddress( '::2001:0DB8::5:1' ),
+ 'IPv6 with a double :: occurrence, firt at beginning'
+ );
$this->assertFalse( IP::isIPAddress( '124.24.52' ), 'IPv4 not
enough quads' );
$this->assertFalse( IP::isIPAddress( '24.324.52.13' ), 'IPv4
out of range' );
$this->assertFalse( IP::isIPAddress( '.24.52.13' ), 'IPv4
starts with period' );
@@ -58,7 +64,10 @@
$this->assertTrue( IP::isIPv6( 'fc:100:a:d:1:e:ac::' ) );
$this->assertFalse( IP::isIPv6( 'fc:100:a:d:1:e:ac:0::' ),
'IPv6 with 8 words ending with "::"' );
- $this->assertFalse( IP::isIPv6( 'fc:100:a:d:1:e:ac:0:1::' ),
'IPv6 with 9 words ending with "::"' );
+ $this->assertFalse(
+ IP::isIPv6( 'fc:100:a:d:1:e:ac:0:1::' ),
+ 'IPv6 with 9 words ending with "::"'
+ );
$this->assertFalse( IP::isIPv6( ':::' ) );
$this->assertFalse( IP::isIPv6( '::0:' ), 'IPv6 ending in a
lone ":"' );
@@ -154,8 +163,14 @@
$this->assertTrue( IP::isValid( 'fc::100:a:d:1' ), 'IPv6 with
"::" and 5 words' );
$this->assertTrue( IP::isValid( 'fc::100:a:d:1:e:ac' ), 'IPv6
with "::" and 7 words' );
- $this->assertFalse( IP::isValid( 'fc:100:a:d:1:e:ac:0::' ),
'IPv6 with 8 words ending with "::"' );
- $this->assertFalse( IP::isValid( 'fc:100:a:d:1:e:ac:0:1::' ),
'IPv6 with 9 words ending with "::"' );
+ $this->assertFalse(
+ IP::isValid( 'fc:100:a:d:1:e:ac:0::' ),
+ 'IPv6 with 8 words ending with "::"'
+ );
+ $this->assertFalse(
+ IP::isValid( 'fc:100:a:d:1:e:ac:0:1::' ),
+ 'IPv6 with 9 words ending with "::"'
+ );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/94159
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6417072270ec7236ad2412abda6f6afce189f0fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
