jenkins-bot has submitted this change and it was merged.
Change subject: Add close elements through code
......................................................................
Add close elements through code
Change-Id: I517221ebcc062477f315c6716e74056c754988a0
---
M includes/installer/WebInstallerOutput.php
M includes/installer/WebInstallerPage.php
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/installer/WebInstallerOutput.php
b/includes/installer/WebInstallerOutput.php
index f2dc37f..6178e5b 100644
--- a/includes/installer/WebInstallerOutput.php
+++ b/includes/installer/WebInstallerOutput.php
@@ -294,9 +294,8 @@
public function outputFooter() {
if ( $this->useShortHeader ) {
-?>
-</body></html>
-<?php
+ echo Html::closeElement( 'body' ) . Html::closeElement(
'html' );
+
return;
}
?>
@@ -317,9 +316,8 @@
</div></div>
</div>
-</body>
-</html>
<?php
+ echo Html::closeElement( 'body' ) . Html::closeElement( 'html'
);
}
public function outputShortHeader() {
diff --git a/includes/installer/WebInstallerPage.php
b/includes/installer/WebInstallerPage.php
index e30373e..1c95d9a 100644
--- a/includes/installer/WebInstallerPage.php
+++ b/includes/installer/WebInstallerPage.php
@@ -185,7 +185,6 @@
}
class WebInstaller_Language extends WebInstallerPage {
-
public function execute() {
global $wgLang;
$r = $this->parent->request;
--
To view, visit https://gerrit.wikimedia.org/r/88500
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I517221ebcc062477f315c6716e74056c754988a0
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Waldir <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
