Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94170
Change subject: Fix error when adding ref with no snaks-order
......................................................................
Fix error when adding ref with no snaks-order
If no snaks-order is passed the module dies
This no longer dies!
Change-Id: Ia9fe1bcd83ab97f8c6854e3cc567fd7241e3b986
---
M repo/includes/api/SetReference.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/70/94170/1
diff --git a/repo/includes/api/SetReference.php
b/repo/includes/api/SetReference.php
index 0db58dd..8b4f54a 100644
--- a/repo/includes/api/SetReference.php
+++ b/repo/includes/api/SetReference.php
@@ -52,10 +52,16 @@
$this->validateReferenceHash( $claim,
$params['reference'] );
}
+ if( isset( $params['snaks-order' ] ) ) {
+ $snaksOrder = $this->getArrayFromParam(
$params['snaks-order'] );
+ } else {
+ $snaksOrder = array();
+ }
+
$newReference = new Reference(
$this->getSnaks(
$this->getArrayFromParam( $params['snaks'] ),
- $this->getArrayFromParam(
$params['snaks-order'] )
+ $snaksOrder
)
);
--
To view, visit https://gerrit.wikimedia.org/r/94170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9fe1bcd83ab97f8c6854e3cc567fd7241e3b986
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
