Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/94254


Change subject: Set visibility on class properties of ExplodeIterator
......................................................................

Set visibility on class properties of ExplodeIterator

Set to private. Only used in StringUtils::explode(). Searched
core and 600+ extensions.

Change-Id: Idbf981d1864f45bbb4adce08803dc693d9a5c200
---
M includes/utils/StringUtils.php
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/54/94254/1

diff --git a/includes/utils/StringUtils.php b/includes/utils/StringUtils.php
index c506a76..5f19e1c 100644
--- a/includes/utils/StringUtils.php
+++ b/includes/utils/StringUtils.php
@@ -525,19 +525,19 @@
  */
 class ExplodeIterator implements Iterator {
        // The subject string
-       var $subject, $subjectLength;
+       private $subject, $subjectLength;
 
        // The delimiter
-       var $delim, $delimLength;
+       private $delim, $delimLength;
 
        // The position of the start of the line
-       var $curPos;
+       private $curPos;
 
        // The position after the end of the next delimiter
-       var $endPos;
+       private $endPos;
 
        // The current token
-       var $current;
+       private $current;
 
        /**
         * Construct a DelimIterator

-- 
To view, visit https://gerrit.wikimedia.org/r/94254
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbf981d1864f45bbb4adce08803dc693d9a5c200
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to