Mwjames has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94260
Change subject: Travis 67.4 / Fix MW 1.23 / DatabaseBase::__construct parameter
array ... was deprecated 1.22
......................................................................
Travis 67.4 / Fix MW 1.23 / DatabaseBase::__construct parameter array ... was
deprecated 1.22
1) SMW\Test\SQLStore\PropertiesCollectorTest::testConstructor
Use of DatabaseBase::__construct method called without parameter array. was
deprecated in MediaWiki
1.22. [Called from PHPUnit_Framework_MockObject_Generator::getObject in
C:\xampp\php\pear\PHPUnit\Fr
amework\MockObject\Generator.php at line 237]
Change-Id: Ic4495b6ae95a58ffbcbf45bb524f85bd577facae
---
M tests/phpunit/includes/storage/sqlstore/PropertiesCollectorTest.php
1 file changed, 3 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki
refs/changes/60/94260/1
diff --git
a/tests/phpunit/includes/storage/sqlstore/PropertiesCollectorTest.php
b/tests/phpunit/includes/storage/sqlstore/PropertiesCollectorTest.php
index 9621a70..c2249cc 100644
--- a/tests/phpunit/includes/storage/sqlstore/PropertiesCollectorTest.php
+++ b/tests/phpunit/includes/storage/sqlstore/PropertiesCollectorTest.php
@@ -56,13 +56,9 @@
'usage_count' => (string)$usageCount //
PropertyStatisticsTable assert ctype_digit
);
- // Database stub object to make the test independent from any
real DB
- $connection = $this->getMock( 'DatabaseMysql' );
-
- // Override method with expected return objects
- $connection->expects( $this->any() )
- ->method( 'select' )
- ->will( $this->returnValue( new FakeResultWrapper(
array( (object)$result ) ) ) );
+ $connection = $this->newMockBuilder()->newObject(
'DatabaseBase', array(
+ 'select' => new FakeResultWrapper( array(
(object)$result ) )
+ ) );
return $connection;
}
--
To view, visit https://gerrit.wikimedia.org/r/94260
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic4495b6ae95a58ffbcbf45bb524f85bd577facae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Mwjames <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
