jenkins-bot has submitted this change and it was merged.
Change subject: Remove exclusive module group to reduce HTTP request
fragmentation
......................................................................
Remove exclusive module group to reduce HTTP request fragmentation
Cache groups should only be used when it is worth to have the
module(s) in a separate request. Echo is relatively small and
stable in terms of cache combination, not worth it to force
its modules to be in a separate http request as all other modules.
Change-Id: I198b5664d662c93c593d048efcfaf4aac765a6b9
---
M Echo.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Echo.php b/Echo.php
index 660e9df..ab502c8 100644
--- a/Echo.php
+++ b/Echo.php
@@ -137,7 +137,6 @@
$echoResourceTemplate = array(
'localBasePath' => $dir . 'modules',
'remoteExtPath' => 'Echo/modules',
- 'group' => 'ext.echo',
);
$wgResourceModules += array(
--
To view, visit https://gerrit.wikimedia.org/r/93053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I198b5664d662c93c593d048efcfaf4aac765a6b9
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Werdna <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
