Hello Ottomata,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/94295

to review the following change.

Change subject: Rename geowiki backups to logs, as they are only logs
......................................................................

Rename geowiki backups to logs, as they are only logs

Change-Id: I454671074bcaf15b42d271c9cf42b14e3e26a31c
---
M manifests/misc/statistics.pp
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/94295/1

diff --git a/manifests/misc/statistics.pp b/manifests/misc/statistics.pp
index 6104dfe..7ad9607 100644
--- a/manifests/misc/statistics.pp
+++ b/manifests/misc/statistics.pp
@@ -897,8 +897,8 @@
 ",
     }
 
-    $geowiki_backups_path = "${geowiki_base_path}/geowiki-backup-data"
-    file { $geowiki_backups_path:
+    $geowiki_log_path = "${geowiki_base_path}/logs"
+    file { $geowiki_log_path:
         ensure  => 'directory',
         owner   => $geowiki_user,
         group   => $geowiki_user,
@@ -907,13 +907,13 @@
     # cron to run geowiki/process_data.py.
     # This will query the production slaves and
     # store results in the research staging database.
-    # Backup files will be kept $geowiki_backups_path.
+    # Logs will be kept $geowiki_log_path.
     cron { 'geowiki-process-data':
         minute  => 0,
         hour    => 12,
         user    => $geowiki_user,
-        command => "/usr/bin/python 
${geowiki_scripts_path}/geowiki/process_data.py -o ${$geowiki_backups_path} 
--wpfiles ${geowiki_scripts_path}/geowiki/data/all_ids.tsv --daily 
--start=`date --date='-2 day' +\\%Y-\\%m-\\%d` --end=`date --date='0 day' 
+\\%Y-\\%m-\\%d` --source_sql_cnf=${geowiki_mysql_globaldev_conf_file} 
--dest_sql_cnf=${geowiki_mysql_research_conf_file}",
-        require => File[$geowiki_backups_path],
+        command => "/usr/bin/python 
${geowiki_scripts_path}/geowiki/process_data.py -o ${$geowiki_log_path} 
--wpfiles ${geowiki_scripts_path}/geowiki/data/all_ids.tsv --daily 
--start=`date --date='-2 day' +\\%Y-\\%m-\\%d` --end=`date --date='0 day' 
+\\%Y-\\%m-\\%d` --source_sql_cnf=${geowiki_mysql_globaldev_conf_file} 
--dest_sql_cnf=${geowiki_mysql_research_conf_file}",
+        require => File[$geowiki_log_path],
     }
 }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/94295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I454671074bcaf15b42d271c9cf42b14e3e26a31c
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: QChris <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to