EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94304
Change subject: Prevent rendering topics like posts
......................................................................
Prevent rendering topics like posts
Topic titles should never be rendered like a post, it will just
cause issues. Blow up instead.
Change-Id: I77ae191d890ae40c0d65682d255e126d69cbc7e6
---
M includes/Templating.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/04/94304/1
diff --git a/includes/Templating.php b/includes/Templating.php
index 5a935a3..0ca7bdf 100644
--- a/includes/Templating.php
+++ b/includes/Templating.php
@@ -93,6 +93,10 @@
public function renderPost( PostRevision $post, Block $block, $return =
true ) {
global $wgFlowTokenSalt;
+ if ( $post->isTopicTitle() ) {
+ throw new \MWException( 'Cannot render topic with ' .
__METHOD__ );
+ }
+
// @todo: I don't like container being pulled in here, improve
this some day
$container = Container::getContainer();
--
To view, visit https://gerrit.wikimedia.org/r/94304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77ae191d890ae40c0d65682d255e126d69cbc7e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
