jenkins-bot has submitted this change and it was merged.
Change subject: Updating reference count when adding/removing references
......................................................................
Updating reference count when adding/removing references
(bug 55891)
Listening to the events of the listview widget managing the referenceview
widget instead
of listening to the inappropriate referenceview events.
Change-Id: I0c0b72ad12a7bcdfff742a35532c476cbc0ca329
---
M lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
index 3ae57ca..8514adc 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.statementview.js
@@ -89,9 +89,11 @@
this._referenceviewLia = $listview.data( 'listview'
).listItemAdapter();
$listview
- .on( 'referenceviewitemadded referenceviewitemremoved',
function( event, value, $li ) {
- self.drawReferencesCounter();
- self._updateReferenceIndices();
+ .on( 'listviewitemadded listviewitemremoved', function(
event, value, $li ) {
+ if( event.target === $listview.get( 0 ) ) {
+ self.drawReferencesCounter();
+ self._updateReferenceIndices();
+ }
} )
.on( 'referenceviewafterstopediting', function( event,
dropValue ) {
if( dropValue ) {
--
To view, visit https://gerrit.wikimedia.org/r/93936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c0b72ad12a7bcdfff742a35532c476cbc0ca329
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
