Mooeypoo has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94375
Change subject: MWExtensionInspector input direction based on content
......................................................................
MWExtensionInspector input direction based on content
** Needs proper testing **
In general, the textarea direction of the MWExtensionInspector textarea
should be dependent on the directionality of the node it is editing.
The only feasible exception is <source> or <code> which are edited
in a separate inspector.
Bug: 56779
Change-Id: Iac5c1c3bf2c61b9fa36c9588c1734c91ca4305c4
---
M modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/94375/1
diff --git a/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
b/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
index 3d3cc57..7039cf0 100644
--- a/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
+++ b/modules/ve-mw/ui/inspectors/ve.ui.MWExtensionInspector.js
@@ -71,6 +71,11 @@
extsrc = this.node.getModel().getAttribute( 'mw' ).body.extsrc;
}
+ // direction of the input textarea should correspond to the
+ // direction of the surrounding content of the node itself
+ // rather than the GUI direction:
+ this.input.$input.attr( 'dir', this.node.$element.css( 'dir' ) );
+
// Wait for animation to complete
setTimeout( ve.bind( function () {
// Setup input text
--
To view, visit https://gerrit.wikimedia.org/r/94375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac5c1c3bf2c61b9fa36c9588c1734c91ca4305c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
