Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/94456


Change subject: SpecialWatchlist: Minor cleanup
......................................................................

SpecialWatchlist: Minor cleanup

* Prettier whitespacing
* Removed query building special-case already handled by makeList()

Change-Id: I45aa7bbbff1e21abd739825939fd5cd3d02fc7a4
---
M includes/specials/SpecialWatchlist.php
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/94456/1

diff --git a/includes/specials/SpecialWatchlist.php 
b/includes/specials/SpecialWatchlist.php
index 336b05b..85913dd 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -60,8 +60,12 @@
                // Add feed links
                $wlToken = $user->getTokenFromOption( 'watchlisttoken' );
                if ( $wlToken ) {
-                       $this->addFeedLinks( array( 'action' => 
'feedwatchlist', 'allrev' => 'allrev',
-                                                               'wlowner' => 
$user->getName(), 'wltoken' => $wlToken ) );
+                       $this->addFeedLinks( array(
+                               'action' => 'feedwatchlist',
+                               'allrev' => 1,
+                               'wlowner' => $user->getName(),
+                               'wltoken' => $wlToken,
+                       ) );
                }
 
                $this->setHeaders();
@@ -205,10 +209,6 @@
                        $nonRevisionTypes = array( RC_LOG );
                        wfRunHooks( 'SpecialWatchlistGetNonRevisionTypes', 
array( &$nonRevisionTypes ) );
                        if ( $nonRevisionTypes ) {
-                               if ( count( $nonRevisionTypes ) === 1 ) {
-                                       // if only one use an equality instead 
of IN condition
-                                       $nonRevisionTypes = reset( 
$nonRevisionTypes );
-                               }
                                $conds[] = $dbr->makeList(
                                        array(
                                                'rc_this_oldid=page_latest',

-- 
To view, visit https://gerrit.wikimedia.org/r/94456
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45aa7bbbff1e21abd739825939fd5cd3d02fc7a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to