jenkins-bot has submitted this change and it was merged.

Change subject: Give the search page a little UI love
......................................................................


Give the search page a little UI love

Uses mediawiki.ui to make the input field more legible and modern,
as well as giving the search button a lovely shade of blue.

Screenshot: https://www.mediawiki.org/wiki/File:Search-UI-minor-tweak.png
Change-Id: I7fdd9970ed5807df94c04bec1681f33523cad173
---
M includes/specials/SpecialSearch.php
M resources/mediawiki.special/mediawiki.special.search.css
2 files changed, 15 insertions(+), 3 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialSearch.php 
b/includes/specials/SpecialSearch.php
index 8c8de8e..dd32656 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -88,7 +88,9 @@
                $this->outputHeader();
                $out = $this->getOutput();
                $out->allowClickjacking();
-               $out->addModuleStyles( 'mediawiki.special' );
+               $out->addModuleStyles( array(
+                       'mediawiki.special', 'mediawiki.special.search', 
'mediawiki.ui'
+               ) );
 
                // Strip underscores from title parameter; most of the time 
we'll want
                // text form here. But don't strip underscores from actual text 
params!
@@ -1093,10 +1095,14 @@
                $out .= Html::input( 'search', $term, 'search', array(
                        'id' => $this->profile === 'advanced' ? 
'powerSearchText' : 'searchText',
                        'size' => '50',
-                       'autofocus'
+                       'autofocus',
+                       'class' => 'mw-ui-input',
                ) ) . "\n";
                $out .= Html::hidden( 'fulltext', 'Search' ) . "\n";
-               $out .= Xml::submitButton( $this->msg( 'searchbutton' )->text() 
) . "\n";
+               $out .= Xml::submitButton(
+                       $this->msg( 'searchbutton' )->text(),
+                       array( 'class' => array( 'mw-ui-button', 
'mw-ui-primary' ) )
+               ) . "\n";
                return $out . $this->didYouMeanHtml;
        }
 
diff --git a/resources/mediawiki.special/mediawiki.special.search.css 
b/resources/mediawiki.special/mediawiki.special.search.css
index 914e47e..7e6e8e6 100644
--- a/resources/mediawiki.special/mediawiki.special.search.css
+++ b/resources/mediawiki.special/mediawiki.special.search.css
@@ -12,3 +12,9 @@
 .searchresult {
        display: inline !ie;
 }
+
+/** Add some extra padding keep browser's "clear field"
+ UI from rubbing up against the side of the field */
+input[type="search"] {
+       padding-right: 0.5em;
+}

-- 
To view, visit https://gerrit.wikimedia.org/r/94276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7fdd9970ed5807df94c04bec1681f33523cad173
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to